fix: ensure notes are stored as null value instead of null string wit…

…h bun insert
determined-ai · Jun 10, 2024 · 47f19fc · 47f19fc
1 parent a83a2ba
commit 47f19fc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/master/internal/project/postgres_project_intg_test.go b/master/internal/project/postgres_project_intg_test.go
@@ -50,8 +50,8 @@ func TestProjectByName(t *testing.T) {
 
 func TestGetProjectByKey(t *testing.T) {
 	require.NoError(t, etc.SetRootPath(internaldb.RootFromDB))
-	testDB, close := internaldb.MustResolveTestPostgres(t)
-	defer close()
+	testDB, closeDB := internaldb.MustResolveTestPostgres(t)
+	defer closeDB()
 	internaldb.MustMigrateTestPostgres(t, testDB, internaldb.MigrationsFromDB)
 
 	// add a workspace, and project
@@ -90,8 +90,8 @@ func TestGetProjectByKey(t *testing.T) {
 
 func TestUpdateProjectKey(t *testing.T) {
 	require.NoError(t, etc.SetRootPath(internaldb.RootFromDB))
-	testDB, close := internaldb.MustResolveTestPostgres(t)
-	defer close()
+	testDB, closeDB := internaldb.MustResolveTestPostgres(t)
+	defer closeDB()
 	internaldb.MustMigrateTestPostgres(t, testDB, internaldb.MigrationsFromDB)
 
 	// add a workspace, and project

diff --git a/master/pkg/model/project.go b/master/pkg/model/project.go
@@ -22,7 +22,7 @@ type Project struct {
 	Username                string            `bun:"username,scanonly"`
 	Immutable               bool              `bun:"immutable"`
 	Description             string            `bun:"description"`
-	Notes                   []*projectv1.Note `bun:"notes,type:jsonb"`
+	Notes                   []*projectv1.Note `bun:"notes,type:jsonb,nullzero"`
 	NumActiveExperiments    int32             `bun:"num_active_experiments,scanonly"`
 	NumExperiments          int32             `bun:"num_experiments,scanonly"`
 	State                   WorkspaceState    `bun:"state,default:'UNSPECIFIED'::workspace_state"`