Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add multi RM name to K8s #8993

Merged
merged 1 commit into from
Mar 14, 2024
Merged

feat: Add multi RM name to K8s #8993

merged 1 commit into from
Mar 14, 2024

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Mar 13, 2024

Description

Display resource manager names (only if there are multiple) for K8s resource pool cards.
Screenshot 2024-03-13 at 12 32 19 PM

Test Plan

For a cluster of K8s, configure multiple resource managers, the resource pool cards should display the resource manager names.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@gt2345 gt2345 requested a review from a team as a code owner March 13, 2024 17:25
@cla-bot cla-bot bot added the cla-signed label Mar 13, 2024
Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 7b82f4a
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65f1e1a99e722500082aebf7
😎 Deploy Preview https://deploy-preview-8993--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 42.76%. Comparing base (978a02e) to head (7b82f4a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8993      +/-   ##
==========================================
- Coverage   47.49%   42.76%   -4.74%     
==========================================
  Files        1168      848     -320     
  Lines      176315   137041   -39274     
  Branches     2353     2351       -2     
==========================================
- Hits        83740    58601   -25139     
+ Misses      92417    78282   -14135     
  Partials      158      158              
Flag Coverage Δ
harness ?
web 42.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/ResourcePoolCard.tsx 43.77% <0.00%> (-0.17%) ⬇️

... and 320 files with indirect coverage changes

@gt2345 gt2345 requested a review from ashtonG March 13, 2024 17:32
@gt2345 gt2345 merged commit 73fd1cd into main Mar 14, 2024
73 of 85 checks passed
@gt2345 gt2345 deleted the gt/101-rm-name-k8s branch March 14, 2024 18:10
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants