Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: limit code coverage report to files in src; omit generated files #9003

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

ashtonG
Copy link
Contributor

@ashtonG ashtonG commented Mar 14, 2024

Description

This PR updates the code reports generated by the frontend unit tests to only report code in the src folder, and omits vendor code and generated code from the reports. This is so the codecoverage report will be more accurate to what we actually care about.

Test Plan

no testing needed

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@ashtonG ashtonG requested a review from a team as a code owner March 14, 2024 19:43
@ashtonG ashtonG requested a review from gt2345 March 14, 2024 19:43
@cla-bot cla-bot bot added the cla-signed label Mar 14, 2024
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 2ab6790
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65f35355f1ea220008cfae22
😎 Deploy Preview https://deploy-preview-9003--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.43%. Comparing base (115bf13) to head (2ab6790).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9003      +/-   ##
==========================================
- Coverage   47.49%   41.43%   -6.07%     
==========================================
  Files        1168      839     -329     
  Lines      176302   103481   -72821     
  Branches     2350     2337      -13     
==========================================
- Hits        83729    42873   -40856     
+ Misses      92415    60455   -31960     
+ Partials      158      153       -5     
Flag Coverage Δ
harness ?
web 40.65% <ø> (-2.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 329 files with indirect coverage changes

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
worked well locally

@ashtonG ashtonG merged commit 5b17df3 into main Mar 15, 2024
72 of 84 checks passed
@ashtonG ashtonG deleted the ET-20/chore/frontend-codecov branch March 15, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants