-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: document ui e2e with backend test instructions for local #9005
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9005 +/- ##
==========================================
- Coverage 47.49% 42.76% -4.74%
==========================================
Files 1168 848 -320
Lines 176315 137050 -39265
Branches 2353 2353
==========================================
- Hits 83742 58603 -25139
+ Misses 92415 78289 -14126
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm great start and we've got more coming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved pending lint fixes.
{ | ||
name: 'chromium-no-cors', | ||
use: { ...devices['Desktop Chrome'], channel: 'chrome', | ||
bypassCSP: true, | ||
launchOptions: { | ||
args: ['--disable-web-security'] | ||
}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine for now, but i'd love to hear more about why this is necessary -- ideally if we're in a situation where we're pointing to a different server, we'd proxy the requests instead. I believe there are vite arguments that we could pass to do this out of the box as well as a proxy script that we use in such situations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, thanks. This was just the fastest way to get going without a full dev build. I'm creating a ticket to remove this and assigning to myself.
* local config * update readme with running instructions * linter fixes * move tests to folder * linting * exculde typo --------- Co-authored-by: Justin Comins <justin.comins@hpe.com>
Description
Mostly a readme change to kick of automating the release party UI tests and give new folks a way to easily check their tests locally.
There's a couple minor changes to the playwright config that shouldn't change functionality, but are useful for running locally.
Test Plan
Tested using the documented setup and it works.
Checklist
docs/release-notes/
.See Release Note for details.
Ticket
INFRAENG-447