Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: document ui e2e with backend test instructions for local #9005

Merged
merged 6 commits into from
Mar 18, 2024

Conversation

djanicekpach
Copy link
Contributor

Description

Mostly a readme change to kick of automating the release party UI tests and give new folks a way to easily check their tests locally.

There's a couple minor changes to the playwright config that shouldn't change functionality, but are useful for running locally.

Test Plan

Tested using the documented setup and it works.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

INFRAENG-447

@djanicekpach djanicekpach requested a review from a team as a code owner March 14, 2024 21:35
@cla-bot cla-bot bot added the cla-signed label Mar 14, 2024
Copy link

netlify bot commented Mar 14, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 9bf1ec7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65f8676a046ca70009b85426
😎 Deploy Preview https://deploy-preview-9005--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 42.76%. Comparing base (978a02e) to head (9bf1ec7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9005      +/-   ##
==========================================
- Coverage   47.49%   42.76%   -4.74%     
==========================================
  Files        1168      848     -320     
  Lines      176315   137050   -39265     
  Branches     2353     2353              
==========================================
- Hits        83742    58603   -25139     
+ Misses      92415    78289   -14126     
  Partials      158      158              
Flag Coverage Δ
harness ?
web 42.82% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/e2e/fixtures/global-fixtures.ts 0.00% <0.00%> (ø)
webui/react/playwright.config.ts 0.00% <0.00%> (ø)

... and 320 files with indirect coverage changes

Copy link
Contributor

@JComins000 JComins000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm great start and we've got more coming

Copy link
Contributor

@ashtonG ashtonG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending lint fixes.

Comment on lines +32 to +38
{
name: 'chromium-no-cors',
use: { ...devices['Desktop Chrome'], channel: 'chrome',
bypassCSP: true,
launchOptions: {
args: ['--disable-web-security']
}},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine for now, but i'd love to hear more about why this is necessary -- ideally if we're in a situation where we're pointing to a different server, we'd proxy the requests instead. I believe there are vite arguments that we could pass to do this out of the box as well as a proxy script that we use in such situations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, thanks. This was just the fastest way to get going without a full dev build. I'm creating a ticket to remove this and assigning to myself.

@djanicekpach djanicekpach merged commit eac7ddf into main Mar 18, 2024
97 of 99 checks passed
@djanicekpach djanicekpach deleted the djanicek/playwright-config branch March 18, 2024 16:30
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
* local config

* update readme with running instructions

* linter fixes

* move tests to folder

* linting

* exculde typo

---------

Co-authored-by: Justin Comins <justin.comins@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants