Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: helm for multirm kubeconfig_path #9015

Merged
merged 10 commits into from
Mar 20, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Mar 18, 2024

Description

Adds helm changes for kubeconfig for multirm.

Test Plan

Deploy kube

minikube --profile=additionalrm

Get context for a gke cluster

gcloud container clusters get-credentials clustername --region=us-west1 
cp ~/.kube/config /tmp/gke

Deploy secrets

kubectl config use-context additionalrm
kubectl create secret generic --from-file /tmp/gke defaultrm
kubectl create secret generic --from-file /tmp/gke additionalrm

Edit values.yaml

additional_resource_managers:
  - resource_manager:
      type: kubernetes
      max_slots_per_pod: 1
      name: "a"
      kubeconfig_secret_name: defaultrm
      kubeconfig_secret_value: gke
      determined_master_ip: 127.0.0.1:8080
      determined_master_port: 8080 # TODO
    resource_pools:
      - pool_name: test_a
  - resource_manager:
      type: kubernetes
      max_slots_per_pod: 1
      name: "b"
      kubeconfig_secret_name: additionalrm
      kubeconfig_secret_value: gke
      determined_master_ip: 127.0.0.1:8080
      determined_master_port: 8080 # TODO
    resource_pools:
    - pool_name: test_b

Deploy (master version shouldn't matter as long as relatively recent)

helm install determined helm/charts/determined/   --values helm/charts/determined/values.yaml   --set maxSlotsPerPod=1   --set detVersion=bc1b431734f396066330508fe6250546c6304dfe

Master should fail with

It looks like you are trying to use a client-go credential plugin that is not installed.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Mar 18, 2024
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 96370f4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65faedfcdaa9bc00086e01b9

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.63%. Comparing base (bc1b431) to head (96370f4).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9015      +/-   ##
==========================================
- Coverage   47.63%   47.63%   -0.01%     
==========================================
  Files        1159     1159              
  Lines      142794   142794              
  Branches     2338     2337       -1     
==========================================
- Hits        68024    68019       -5     
- Misses      74617    74622       +5     
  Partials      153      153              
Flag Coverage Δ
backend 42.57% <ø> (-0.01%) ⬇️
harness 63.98% <ø> (-0.01%) ⬇️
web 40.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@NicholasBlaskey NicholasBlaskey marked this pull request as ready for review March 20, 2024 14:09
Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a values.yaml example? or are you going to put that in a separate PR?

@NicholasBlaskey
Copy link
Contributor Author

missing a values.yaml example? or are you going to put that in a separate PR?

I don't want to add things to values.yaml before they are released since it is a public file people are going to be using.

@carolinaecalderon
Copy link
Contributor

missing a

missing a values.yaml example? or are you going to put that in a separate PR?

I don't want to add things to values.yaml before they are released since it is a public file people are going to be using.

This is going to be included in the next release, afaik this change is the last we're waiting on?

@NicholasBlaskey
Copy link
Contributor Author

missing a

missing a values.yaml example? or are you going to put that in a separate PR?

I don't want to add things to values.yaml before they are released since it is a public file people are going to be using.

This is going to be included in the next release, afaik this change is the last we're waiting on?

I can add it in a seperate PR after we create the example tutorial/setup docs.

@NicholasBlaskey NicholasBlaskey merged commit 6fec24d into main Mar 20, 2024
69 of 81 checks passed
@NicholasBlaskey NicholasBlaskey deleted the update_helm_for_byoconf_multirm branch March 20, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants