Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove parent_id from create_experiment #9068

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Mar 28, 2024

Description

Follow up for #8927
Since parent id is mostly used internally, and can be confusing for end user when exposed, we decide to remove it from SDK function create_experiment

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@gt2345 gt2345 requested a review from a team as a code owner March 28, 2024 17:52
@cla-bot cla-bot bot added the cla-signed label Mar 28, 2024
@gt2345 gt2345 added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Mar 28, 2024
Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ed6fd90
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6605ae6ae2b1fb00080db5c4

@gt2345 gt2345 requested review from wes-turner and removed request for azhou-determined March 28, 2024 17:53
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 47.15%. Comparing base (17287f5) to head (ed6fd90).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9068   +/-   ##
=======================================
  Coverage   47.15%   47.15%           
=======================================
  Files        1152     1152           
  Lines      141866   141866           
  Branches     2416     2416           
=======================================
  Hits        66897    66897           
  Misses      74779    74779           
  Partials      190      190           
Flag Coverage Δ
backend 42.99% <ø> (ø)
harness 64.31% <0.00%> (ø)
web 38.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rness/determined/common/experimental/determined.py 41.21% <ø> (ø)
harness/determined/experimental/client.py 55.26% <0.00%> (ø)

Copy link
Contributor

@wes-turner wes-turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wes-turner wes-turner merged commit 1e45918 into main Mar 28, 2024
74 of 86 checks passed
@wes-turner wes-turner deleted the gt/remove-parentid-from-create_experiment branch March 28, 2024 18:25
dai-release bot pushed a commit that referenced this pull request Mar 28, 2024
Follow up for #8927
Since parent id is mostly used internally, and can be confusing for end user when exposed, we decide to remove it from SDK function create_experiment

(cherry picked from commit 1e45918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants