Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Admin Settings to NavigationTabbar (ET-194) #9423

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented May 24, 2024

Ticket

ET-194

Description

Adds "Admin Settings" to mobile navigation menu (if user has admin permissions)
Also renames "Settings" option to "User Settings"

Test Plan

  • Open app in mobile mode.
  • Click three-dot menu on lower right.
  • User with admin permissions should see "Admin Settings" option which leads to Admin Settings page
  • User without admin permissions should not see that option

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@johnkim-det johnkim-det requested a review from a team as a code owner May 24, 2024 15:18
@cla-bot cla-bot bot added the cla-signed label May 24, 2024
Copy link

netlify bot commented May 24, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit e451698
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6650f7be3d7bc90008fb843a
😎 Deploy Preview https://deploy-preview-9423--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johnkim-det johnkim-det requested review from keita-determined and removed request for julian-determined-ai May 24, 2024 15:19
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 43.44%. Comparing base (cdd7a82) to head (e451698).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9423      +/-   ##
==========================================
- Coverage   48.61%   43.44%   -5.18%     
==========================================
  Files        1233      909     -324     
  Lines      158972   119056   -39916     
  Branches     2778     2778              
==========================================
- Hits        77278    51718   -25560     
+ Misses      81520    67164   -14356     
  Partials      174      174              
Flag Coverage Δ
harness ?
web 44.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/NavigationTabbar.tsx 0.00% <0.00%> (ø)

... and 324 files with indirect coverage changes

Copy link
Contributor

@keita-determined keita-determined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnkim-det johnkim-det merged commit 515c135 into main May 28, 2024
84 of 97 checks passed
@johnkim-det johnkim-det deleted the ET-194 branch May 28, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants