Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: address two link check failures #9539

Merged
merged 4 commits into from
Jun 18, 2024
Merged

docs: address two link check failures #9539

merged 4 commits into from
Jun 18, 2024

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented Jun 18, 2024

hashicorp just updated their doc link structure. and wso2 link doesn't allow our crawler.

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

hashicorp just updated their doc link structure. and
wso2 link doesn't allow our crawler.
@cla-bot cla-bot bot added the cla-signed label Jun 18, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jun 18, 2024
@determined-ci determined-ci requested a review from a team June 18, 2024 18:55
Copy link

netlify bot commented Jun 18, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 33a2682
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6671e4a9a702ae0009fcb426

@hamidzr hamidzr requested a review from a team as a code owner June 18, 2024 18:55
@hamidzr hamidzr requested review from djanicekpach and NicholasBlaskey and removed request for djanicekpach June 18, 2024 18:55
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.28%. Comparing base (3641bfc) to head (06f8324).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9539      +/-   ##
==========================================
+ Coverage   49.88%   52.28%   +2.40%     
==========================================
  Files        1245      752     -493     
  Lines      161903   112223   -49680     
  Branches     2886     2887       +1     
==========================================
- Hits        80762    58677   -22085     
+ Misses      80970    53375   -27595     
  Partials      171      171              
Flag Coverage Δ
backend 34.25% <ø> (-9.73%) ⬇️
harness 63.81% <ø> (ø)
web 46.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 494 files with indirect coverage changes

@hamidzr hamidzr merged commit 7568129 into main Jun 18, 2024
81 of 94 checks passed
@hamidzr hamidzr deleted the nbp-doclinks branch June 18, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants