Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tabs to Uncategorized page (ET-310) #9547

Merged
merged 2 commits into from
Jun 25, 2024
Merged

feat: add tabs to Uncategorized page (ET-310) #9547

merged 2 commits into from
Jun 25, 2024

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Jun 20, 2024

Ticket

ET-310

Description

With Flat Runs feature flag on, make "Runs", "Searches", "Notes" tabs visible on the Uncategorized page.

Test Plan

With Flat Runs feature flag on, on Uncategorized page:

  • "Runs" tab appears with runs for uncategorized project
  • "Searches" tab appears with searches for uncategorized project
  • "Notes" tabs appears, can add/edit/delete notes for uncategorized project

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@johnkim-det johnkim-det added the feature-flagged The changes in this PR are behind a feature flag label Jun 20, 2024
@johnkim-det johnkim-det requested a review from a team as a code owner June 20, 2024 18:18
@johnkim-det johnkim-det requested a review from gt2345 June 20, 2024 18:18
@cla-bot cla-bot bot added the cla-signed label Jun 20, 2024
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 7d3559c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6674729487ec5200080b7a62
😎 Deploy Preview https://deploy-preview-9547--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johnkim-det johnkim-det removed the request for review from gt2345 June 20, 2024 18:19
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 45.29%. Comparing base (ea929fc) to head (7d3559c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9547      +/-   ##
==========================================
- Coverage   49.90%   45.29%   -4.61%     
==========================================
  Files        1245      921     -324     
  Lines      161903   121619   -40284     
  Branches     2887     2886       -1     
==========================================
- Hits        80795    55087   -25708     
+ Misses      80937    66361   -14576     
  Partials      171      171              
Flag Coverage Δ
harness ?
web 46.24% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/pages/ProjectDetails.tsx 0.00% <0.00%> (ø)

... and 324 files with indirect coverage changes

Copy link
Contributor

@EmilyBonar EmilyBonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnkim-det johnkim-det merged commit 9413e24 into main Jun 25, 2024
90 of 103 checks passed
@johnkim-det johnkim-det deleted the ET-310 branch June 25, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed feature-flagged The changes in this PR are behind a feature flag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants