Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Retag docker images using CI #9562

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

MikhailKardash
Copy link
Contributor

@MikhailKardash MikhailKardash commented Jun 24, 2024

Ticket

Description

Add retagging scripts to release party via filters. Update the necessary python and bash scripts.

Test Plan

Release party doesn't break

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@MikhailKardash MikhailKardash requested a review from a team as a code owner June 24, 2024 22:59
@cla-bot cla-bot bot added the cla-signed label Jun 24, 2024
Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 1c47f4c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668da3cceec77e00083c6269
😎 Deploy Preview https://deploy-preview-9562--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JComins000
Copy link
Contributor

why doesnt this have an issue attached? how did you test the changes?

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.79%. Comparing base (c87f04e) to head (1c47f4c).
Report is 51 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9562      +/-   ##
==========================================
- Coverage   49.81%   47.79%   -2.02%     
==========================================
  Files        1247      614     -633     
  Lines      162241   101165   -61076     
  Branches     2888     2888              
==========================================
- Hits        80814    48352   -32462     
+ Misses      81255    52641   -28614     
  Partials      172      172              
Flag Coverage Δ
backend 34.21% <ø> (-9.71%) ⬇️
harness 52.85% <ø> (-10.90%) ⬇️
web 46.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 696 files with indirect coverage changes

@MikhailKardash MikhailKardash marked this pull request as draft June 25, 2024 16:17
@JComins000
Copy link
Contributor

can you close this? i keep getting pings

@JComins000
Copy link
Contributor

gonna unassign myself as reviewer. add me back when this moves into ready for review

@JComins000 JComins000 removed their request for review July 8, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants