-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: API requests with single RM and recover from panic during unauthorized autocreate #9573
base: wksp-namespace-binding
Are you sure you want to change the base?
Conversation
…espace bindings (#9226)
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## wksp-namespace-binding #9573 +/- ##
==========================================================
- Coverage 52.11% 43.52% -8.60%
==========================================================
Files 753 578 -175
Lines 112830 99830 -13000
Branches 2888 2888
==========================================================
- Hits 58806 43449 -15357
- Misses 53852 56209 +2357
Partials 172 172
Flags with carried forward coverage won't be shown. Click here to find out more. |
82011dc
to
71d5420
Compare
71d5420
to
86f8657
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cd9b184
to
1ee0bbf
Compare
Ticket
DET-10385, DET-10386
Description
This PR fixes the following issues:
Test Plan
Spin up a single RM kubernetes EE cluster to execute the test plan.
To test API requests for single RM, run the following commands and make sure that they work:
det w create ws1 --auto-create-namesapce
det w create ws2 && det w bindings set ws2 --namespace default
det w create ws3 --namespace default
det w create ws4 && det w bindings set --auto-create-namespace
To test auto-create panic handled gracefully with an intuitive error message:
license.txt
andpublic.txt
from yourdetermined
directory).det w create ws10 --auto-create-namespace
and verify that we get an error saying that auto create is an EE-only featuredet w create ws11 && det w bindings set ws11 --auto-create-namespace
and verify that we get an error saying that auto create is an EE-only featureTo test namespace auto-creation with workspaces whose names don't match the accepted namespace regex pattern, run
det w create name,of_workspacE --auto-create-namespace
and verify that a Kubernetes namespace is successfully createddet w create ANOTHER,name,of_workspacE && det w bindings set ANOTHER,name,of_workspacE --auto-create-namespace
and verify that a Kubernetes namespace is successfully createdChecklist
docs/release-notes/
See Release Note for details.