-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pause unpause UX #9615
feat: pause unpause UX #9615
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9615 +/- ##
==========================================
- Coverage 52.88% 48.24% -4.64%
==========================================
Files 1255 932 -323
Lines 153087 124035 -29052
Branches 3230 3239 +9
==========================================
- Hits 80961 59843 -21118
+ Misses 71975 64041 -7934
Partials 151 151
Flags with carried forward coverage won't be shown. Click here to find out more.
|
df69351
to
09718b0
Compare
09718b0
to
77b99e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionality looks good!
one minor issue is that the toasts for bulk actions say "1 runs" instead of "1 run" -- not introduced by this PR but should be a quick fix to use the pluralizer
util in submitBatchAction
in TableActionBar
and FlatRunActionButton
also think patch coverage will probably hit 80% by adding assertions that mocked pauseRuns
and resumeRuns
are called (see killRuns
test case example).
fixed |
Ticket
ET-293
Description
Support pause/unpause in flat run table
from ET-293
Test Plan
Checklist
docs/release-notes/
See Release Note for details.