Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pause unpause UX #9615

Merged
merged 6 commits into from
Jul 9, 2024
Merged

feat: pause unpause UX #9615

merged 6 commits into from
Jul 9, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Jul 6, 2024

Ticket

ET-293

Description

Support pause/unpause in flat run table

In context menu, if you run is part of a search it should be disabled. In bulk actions dropdown, we send request unmodified, and we need to interpret error where trial is part of a multi trial and raise it as part of a toast.

from ET-293

Test Plan

  • Pause/Unpause should work in the context menu and bulk action

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 6, 2024
Copy link

netlify bot commented Jul 6, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 655c7f4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668d93f3715a2d0008a2d71f
😎 Deploy Preview https://deploy-preview-9615--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 92.03540% with 9 lines in your changes missing coverage. Please review.

Project coverage is 48.24%. Comparing base (547a4c4) to head (655c7f4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9615      +/-   ##
==========================================
- Coverage   52.88%   48.24%   -4.64%     
==========================================
  Files        1255      932     -323     
  Lines      153087   124035   -29052     
  Branches     3230     3239       +9     
==========================================
- Hits        80961    59843   -21118     
+ Misses      71975    64041    -7934     
  Partials      151      151              
Flag Coverage Δ
harness ?
web 51.36% <92.03%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/services/api.ts 97.69% <100.00%> (+0.02%) ⬆️
webui/react/src/services/apiConfig.ts 74.15% <100.00%> (+0.24%) ⬆️
webui/react/src/types.ts 99.68% <100.00%> (+<0.01%) ⬆️
webui/react/src/utils/flatRun.ts 98.68% <100.00%> (+0.17%) ⬆️
webui/react/src/components/RunActionDropdown.tsx 95.59% <97.61%> (+0.91%) ⬆️
...i/react/src/pages/FlatRuns/FlatRunActionButton.tsx 73.23% <68.00%> (+1.31%) ⬆️

... and 325 files with indirect coverage changes

@keita-determined keita-determined marked this pull request as ready for review July 8, 2024 20:21
@keita-determined keita-determined requested a review from a team as a code owner July 8, 2024 20:21
Copy link
Contributor

@johnkim-det johnkim-det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality looks good!

one minor issue is that the toasts for bulk actions say "1 runs" instead of "1 run" -- not introduced by this PR but should be a quick fix to use the pluralizer util in submitBatchAction in TableActionBar and FlatRunActionButton

also think patch coverage will probably hit 80% by adding assertions that mocked pauseRuns and resumeRuns are called (see killRuns test case example).

@keita-determined
Copy link
Contributor Author

functionality looks good!

one minor issue is that the toasts for bulk actions say "1 runs" instead of "1 run" -- not introduced by this PR but should be a quick fix to use the pluralizer util in submitBatchAction in TableActionBar and FlatRunActionButton

also think patch coverage will probably hit 80% by adding assertions that mocked pauseRuns and resumeRuns are called (see killRuns test case example).

fixed

@keita-determined keita-determined merged commit 3a8c042 into main Jul 9, 2024
81 of 94 checks passed
@keita-determined keita-determined deleted the feature/pause-unpause branch July 9, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants