-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Onboarding Modal Styling #1038
Add Onboarding Modal Styling #1038
Conversation
|
display: flex; | ||
align-items: center; | ||
background-color: ${theme.colors.Black}; | ||
color: #F0EDEE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the color present in the Figma design and in packages\UI\src\styles\theme.ts
I wasn't able to use ${theme.color.GREYSCALE_OFF_WHITE} to get that because I am using the theme in the file path import theme from "../../../styles/theme";
I have tried using import {theme as theme1} from ... and import {theme as theme1} from ... but it was not working. that is why I am not using the build in colour from the theme file here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THis is fine, i will be configuring the styling system for user profile project later on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HavreLoic theme can used as follows
${({ theme }) =>theme.color.GREYSCALE_OFF_WHITE };
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes @Enjoy2Live we are first using hard-coded values until the issue of the duplicated them file is addressed
${'' /* Enter styling */} | ||
`; | ||
|
||
export const ModalBody = styled.div` | ||
padding: 0 120px; | ||
padding: 0 115px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Padding from the Figma design
padding: 0 120px; | ||
padding: 0 115px; | ||
|
||
h2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gonna get you to make some changes here to reflect the changes I'm planning for next week, I'll speak to you about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this PR open so you can update this with the changes i need you to make.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed the changes I've asked you to make, looks good. I'll start mapping the styling.
No description provided.