Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development/user profile #1833

Closed
wants to merge 76 commits into from
Closed

Conversation

tiwarineelu59
Copy link
Contributor

No description provided.

rinagobo and others added 30 commits January 24, 2024 17:13
removed comments
removed console log
removed console logs and reverted default values for showIntroductionModal and showPlatformOnboardingModal
Reverted capitalization of imports
removed comments and console logs
removed console logs
judeamos and others added 25 commits April 20, 2024 13:38
…modal-1263-Final-Changes

CloseModalFinalChanges-Task1263-UI-Error-Fix
…undation

Judeamos/overview page foundation
Readded the comments in the useUserDataHook function
Added error checking for first/last name validation
…ackend-final

Profile Picture Backend Final PR
@tiwarineelu59 tiwarineelu59 requested review from a team as code owners June 19, 2024 19:29
Copy link

changeset-bot bot commented Jun 19, 2024

⚠️ No Changeset found

Latest commit: 6433a57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@Enjoy2Live Enjoy2Live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's abstain from making gigantic PRs to master so we can easily review and give feedback.

I reviewed the parts that are relevant to me only as I can't go over all the changes, please read the requested change and let me know what you think here.

@@ -1,75 +1,50 @@
import { NewApplicant, Opportunity, Project, User as UserType, Idea, Like, Save } from "@devlaunchers/models";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we revert the changes that removed comments from this file packages/utility/agent.ts? why have you removed it in the first place if I may ask?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants