Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create the collection in ansible-galaxy #407

Closed
joubbi opened this issue Feb 24, 2021 · 5 comments · Fixed by #493
Closed

Please create the collection in ansible-galaxy #407

joubbi opened this issue Feb 24, 2021 · 5 comments · Fixed by #493

Comments

@joubbi
Copy link
Contributor

joubbi commented Feb 24, 2021

Is your feature request related to a problem? Please describe.
I would like to download the collection and it's dependencies with the command ansible-galaxy collection download dev-sec.os-hardening -p ~/offline-collections.
I guess that other users would like to install the collection with the ansible-galaxy command as well.

The collection has a dependency to the community.crypto collection, which I think is not specified in the dependencies.

Bonus bug:
https://github.com/dev-sec/ansible-collection-hardening/blob/master/roles/os_hardening/meta/main.yml
The description and min_ansible_version needs updating.
(The role is not for SSH and I know that at least Ansible version 2.9.something is needed.)

Describe the solution you'd like
Add the role to Galaxy.

@rndmh3ro
Copy link
Member

Can you try this command?

ansible-galaxy collection install devsec.hardening

The collection has a dependency to the community.crypto collection, which I think is not specified in the dependencies.

It is here: https://github.com/dev-sec/ansible-collection-hardening/blob/master/galaxy.yml#L20-L21

The description and min_ansible_version needs updating.

Thanks, needs to be fixed.

@joubbi
Copy link
Contributor Author

joubbi commented Feb 24, 2021

Thank you!
I tried to find the command to install the collection here on GitHub. I couldn't find it.
Shouldn't it be on the main readme under "Using this collection"?

Google gives only results for the other older galaxy page with a dash: https://galaxy.ansible.com/dev-sec
It's a little confusing that you have another one without the dash: https://galaxy.ansible.com/devsec

@rndmh3ro
Copy link
Member

Shouldn't it be on the main readme under "Using this collection"?

I added it.

t's a little confusing that you have another one without the dash

Yeah, one day the Ansible team defined that names should not have dashes in them, that's why we had to create the new namespace. The old namespace with the dash is for backwards compatibility.

@joubbi
Copy link
Contributor Author

joubbi commented Feb 25, 2021

I understand. If you're still able to do changes in the old namespace, it would probably help others if you had a comment there steering people to the right one.

@joubbi joubbi closed this as completed Feb 25, 2021
@rndmh3ro rndmh3ro reopened this Feb 25, 2021
@rndmh3ro
Copy link
Member

I'll keep this open to add a note to the old roles and fix the min_ansible_version.

rndmh3ro added a commit that referenced this issue Oct 20, 2021
rndmh3ro added a commit that referenced this issue Oct 20, 2021
fixes #407

Signed-off-by: rndmh3ro <github@gumpri.ch>
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
fixes dev-sec#407

Signed-off-by: rndmh3ro <github@gumpri.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants