Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change minimize access method #181

Merged
merged 3 commits into from Aug 1, 2018
Merged

change minimize access method #181

merged 3 commits into from Aug 1, 2018

Conversation

rndmh3ro
Copy link
Member

@rndmh3ro rndmh3ro commented Jul 23, 2018 •
edited

This fixes #171. Looping over lists and changing the files of these lists is a PITA.

@jokimaki
Copy link

jokimaki commented Aug 1, 2018

I tried this an got ERROR! The field 'loop' is supposed to be a string type, however the incoming data structure is a <class 'ansible.parsing.yaml.objects.AnsibleSequence'> with ansible 2.4.6. Works great after I upgraded to 2.5.7. I thought I'd bring this to your attention if you still wish to support Ansible 2.4 or if min_ansible_version in meta/main.yml should be updated to 2.5 before merging.

Looking forward to seeing this on master, I can confirm that the infinite recursion issue is fixed on Ubuntu 16.06. Thanks!

@rndmh3ro
Copy link
Member Author

rndmh3ro commented Aug 1, 2018

Thanks for testing this, @jokimaki!

@rndmh3ro rndmh3ro merged commit 30aa3fe into master Aug 1, 2018
@rndmh3ro rndmh3ro deleted the minimize_access branch August 1, 2018 19:35
@rndmh3ro rndmh3ro added bug and removed in progress labels Sep 2, 2018
@jrgriffiniii jrgriffiniii mentioned this pull request Sep 5, 2018
Closed
rndmh3ro added a commit that referenced this pull request Jul 24, 2020
@rndmh3ro
Merge pull request #181 from dev-sec/kitchen_travis
6b2e45c 
remove oracle7 from travis tests for the time being
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
@rndmh3ro
Merge pull request dev-sec#181 from dev-sec/minimize_access
164fb6c 
change minimize access method
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
@rndmh3ro
Merge pull request dev-sec#181 from dev-sec/kitchen_travis
74235bf 
remove oracle7 from travis tests for the time being
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minimize_access: maximum recursion depth exceeded on Ansible 2.5
2 participants
@rndmh3ro @jokimaki