Added fedora support #206
Added fedora support #206
Conversation
Added to version check "|int" so jinja2 will do proper int comparison
Added failed_when to "activate gpg-check for yum-repos" because yum.conf is replaced in newer fedora versions.
Task only fails if error is not "file doesn't exists"
Signed-off-by: Jonas Wrede <jonwrede@users.noreply.github.com>
tasks/pam.yml
Outdated
| @@ -71,14 +71,14 @@ | |||
| yum: | |||
| name: '{{ os_packages_pam_cracklib }}' | |||
| state: 'absent' | |||
| when: (ansible_os_family == 'RedHat' and ansible_distribution_version < '7' and not ansible_distribution == 'Amazon') | |||
| when: (ansible_os_family == 'RedHat' and ansible_distribution_version | int < 7 and not ansible_distribution == 'Amazon') | |||
There was a problem hiding this comment.
You may as well use the version_compare filter which is designed for this:
when: (ansible_os_family == 'RedHat' and ansible_distribution_version | version_compare('7', '<') and not ansible_distribution == 'Amazon')
There was a problem hiding this comment.
Okay will do, didn't know where such a thing
Signed-off-by: Jonas Wrede <jonas.wrede@student.fh-kiel.de>
Signed-off-by: Jonas Wrede <jonas.wrede@student.fh-kiel.de>
| @@ -27,8 +27,11 @@ | |||
| dest: '{{ item }}' | |||
| regexp: '^\s*gpgcheck: 0' | |||
| replace: 'gpgcheck: 1' | |||
| register: status | |||
| failed_when: status.rc is defined and status.rc != 257 | |||
There was a problem hiding this comment.
Cool idea! Can you add a comment here indicating what it does?
Signed-off-by: Jonas Wrede <jonas.wrede@student.fh-kiel.de>
Signed-off-by: Jonas Wrede <jonas.wrede@student.fh-kiel.de>
|
@rndmh3ro I saw you have a fedora image on you docker hub, but im not sure which value is needed for run_opts |
Signed-off-by: Jonas Wrede <jonas.wrede@student.fh-kiel.de>
The ones you used are fine. However in the fedora-image no python is installed... I have to fix this (or you can create a PR, if you want to) |
|
Hey @jonwrede, the ansible run is working now, however there seems to be another problem here... |
|
@rndmh3ro it seems to be an docker/travis error. Maybe the run_opts is wrong. I can confirm that the error doesn't happen on a fresh fedora 29 install on a dedicated maschine. In Centos that task is skiped. And default value of os_security_suid_sgid_remove_from_unknown is false but in test.yml its set to true |
|
The problem was that on the docker-image not only python was missing, but also the Thanks for your efforts! |
Added fedora support
Added to version check "|int" so jinja2 will do proper int comparison
Added failed_when to "activate gpg-check for yum-repos" because yum.conf is replaced in newer fedora versions. Task only fails if error is not "file doesn't exists"
Signed-off-by: Jonas Wrede jonwrede@users.noreply.github.com