Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use find module instead of shell #294

Merged
merged 3 commits into from Aug 16, 2020
Merged

use find module instead of shell #294

merged 3 commits into from Aug 16, 2020

Conversation

danielkubat
Copy link
Contributor

  • replace shell by find module
  • regexp fixes when activating gpgcheck to cover more scenarios

solves: #293

Signed-off-by: danielkubat dan.kubat@gmail.com

Signed-off-by: danielkubat <dan.kubat@gmail.com>
@danielkubat
Copy link
Contributor Author

danielkubat commented Aug 12, 2020

Travis test is failing due to missing /sbin/init binary in source Fedora image and hardcoded init ENV in travis configuration:
https://github.com/dev-sec/ansible-os-hardening/blob/eb777fbe2f1f8677ff80b9cf5f37bedb9648476e/.travis.yml#L7

Related issue: dev-sec/docker-ansible#8
PR: dev-sec/docker-ansible#9

tasks/yum.yml Show resolved Hide resolved
tasks/yum.yml Outdated Show resolved Hide resolved
tasks/yum.yml Show resolved Hide resolved
Signed-off-by: danielkubat <dan.kubat@gmail.com>
tasks/yum.yml Outdated Show resolved Hide resolved
@rndmh3ro rndmh3ro merged commit 2c4505a into dev-sec:master Aug 16, 2020
@rndmh3ro
Copy link
Member

I went ahead and merged it. Thank you!

rndmh3ro added a commit that referenced this pull request Nov 8, 2020
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
* use find module to find yum repos, regexp fixes

Signed-off-by: danielkubat <dan.kubat@gmail.com>

* use loop instead of with_*

Signed-off-by: danielkubat <dan.kubat@gmail.com>

* Update tasks/yum.yml

Co-authored-by: Sebastian Gumprich <rndmh3ro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants