do not touch sysctl file to avoid idempotency problems #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schurzi
approved these changes
Sep 19, 2020
|
@rndmh3ro please sign off your commits before merging :) |
nodiscc
reviewed
Sep 19, 2020
| @@ -5,7 +5,7 @@ | |||
| owner: 'root' | |||
| group: 'root' | |||
| mode: '0440' | |||
| state: touch | |||
| state: file | |||
There was a problem hiding this comment.
You will run into errors with this if the file does not exist (ansible file module errors out whenstate: file is used on a non-existent path). The proper way to fix idempotence is
state: touch
modification_time: preserve
access_time: preservehttps://docs.ansible.com/ansible/latest/modules/file_module.html
There was a problem hiding this comment.
That is why it was touch, not file! Thanks! That's what happens if you don't document your code.
I'll fix thix.
rndmh3ro
added a commit
that referenced
this pull request
Nov 8, 2020
* add testing for CentOS8 Adds testing environments for CentOS8 to local Kitchen and remote Travis tests. Currently only local Kitchen Docker tests are verified. Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * disable system wide CRYPTO_POLICY on RHEL8+ by default sshd will not use the crypto settings from sshd_config. To make the settings effective we need to disable the system wide CRYPTO_POLICY. see: https://access.redhat.com/solutions/4410591 Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * Set volume variable for travis tests to use cgroups mount where needed Signed-off-by: Sebastian Gumprich <github@gumpri.ch> Co-authored-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com> Co-authored-by: Sebastian Gumprich <rndmh3ro@users.noreply.github.com>
wkhayrattee
added a commit
to wak-automation/ansible-os-hardening
that referenced
this pull request
Nov 27, 2021
See related ticket: - dev-sec#310 - dev-sec#309
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
* add testing for CentOS8 Adds testing environments for CentOS8 to local Kitchen and remote Travis tests. Currently only local Kitchen Docker tests are verified. Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * disable system wide CRYPTO_POLICY on RHEL8+ by default sshd will not use the crypto settings from sshd_config. To make the settings effective we need to disable the system wide CRYPTO_POLICY. see: https://access.redhat.com/solutions/4410591 Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * Set volume variable for travis tests to use cgroups mount where needed Signed-off-by: Sebastian Gumprich <github@gumpri.ch> Co-authored-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com> Co-authored-by: Sebastian Gumprich <rndmh3ro@users.noreply.github.com>
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.