Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements of comments in opensshd.conf.j2 #338 #339

Merged
merged 2 commits into from Dec 12, 2020
Merged

Improvements of comments in opensshd.conf.j2 #338 #339

merged 2 commits into from Dec 12, 2020

Conversation

joubbi
Copy link
Contributor

@joubbi joubbi commented Dec 11, 2020

Some of the comments were bad. I improved them.
They are probably not perfect, but better.

@rndmh3ro
Copy link
Member

Thanks, looks great! Can you please sign off your commits? Then I'll merge it.

@joubbi
Cut some long comments into two rows for easier reading.
7457396 
Signed-off-by: joubbi <farid@joubbi.se>
@joubbi
Copy link
Contributor Author

joubbi commented Dec 12, 2020 via email

@rndmh3ro
Copy link
Member

You signed-off one commit, but not the other. Okay for me, since it is a minor change only.

Thanks for your help!

@rndmh3ro rndmh3ro merged commit 91424ac into dev-sec:master Dec 12, 2020
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
@joubbi
Improvements of comments in opensshd.conf.j2 dev-sec#338 (dev-sec#339)
b8e23c3 
* Fixed some comments that had issues. See dev-sec#338

* Cut some long comments into two rows for easier reading.

Signed-off-by: joubbi <farid@joubbi.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement patch ssh_hardening
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joubbi @rndmh3ro