Sorted sysctl values and lists in READMEs alphabetically (No functional changes). #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Farid Joubbi <farid@joubbi.se>
Signed-off-by: Farid Joubbi <farid@joubbi.se>
Signed-off-by: Farid Joubbi <farid@joubbi.se>
Signed-off-by: Farid Joubbi <farid@joubbi.se>
Signed-off-by: Farid Joubbi <farid@joubbi.se>
Signed-off-by: Farid Joubbi <farid@joubbi.se>
rndmh3ro
approved these changes
Jan 8, 2021
|
Thanks! I like your attention to detail. Just one minor thing to correct. |
|
I figured that it's nicer to have the fully supported stuff first.
Also, I noticed later that os hardening comes first somewhere in a readme before nginx and mysql. I figured that I'll leave it that way.
…On January 8, 2021 7:04:35 PM UTC, Sebastian Gumprich ***@***.***> wrote:
@rndmh3ro approved this pull request.
> - Debian 9/10
+ - Ubuntu 16.04/18.04/20.04
+ - Amazon Linux (some roles supported)
This is not alphabetically. :)
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#371 (review)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
…al changes). (dev-sec#371) * Add s's for consistency. Signed-off-by: Farid Joubbi <farid@joubbi.se> * Sort lists alphabetically. Signed-off-by: Farid Joubbi <farid@joubbi.se> * Sorted sysctl_config alphabetically. Signed-off-by: Farid Joubbi <farid@joubbi.se> * Sort removed protocols. Signed-off-by: Farid Joubbi <farid@joubbi.se> * Added dots in variable descriptions for the sake of consistency. Signed-off-by: Farid Joubbi <farid@joubbi.se> * Added dots in variable descriptions for the sake of consistency. Signed-off-by: Farid Joubbi <farid@joubbi.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some lists in alphabetical order.
Added a dot after each sentence in the variable descriptions in the READMEs.
Almost one half of the sentences ended in a dot while the other half did not...
This PR is related to #359