Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os_auth_pam_pwquality_options: Changed type to authtok_type #432

Merged
merged 1 commit into from Mar 23, 2021

Conversation

joubbi
Copy link
Contributor

@joubbi joubbi commented Mar 23, 2021

I couldn't find any reliable documentation about type=.
I could find about authtok_type=.
For example here: https://linux.die.net/man/8/pam_pwquality and
https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html-single/system-level_authentication_guide/index

Both type=foobar and authtok_type=foobar changes the password prompt the same way.
So I don't know if there is a difference, but since most documentation says authtok_type=...

The default for RHEL7/8 is to have an empty type. So the authtok_type=is not actually needed.
It could be removed completely and maybe it should, for less confusion.

Signed-off-by: Farid Joubbi farid@joubbi.se

Signed-off-by: Farid Joubbi <farid@joubbi.se>
@schurzi schurzi changed the title Changed os_auth_pam_pwquality_options type to authtok_type. Changed os_auth_pam_pwquality_options type to authtok_type Mar 23, 2021
@schurzi schurzi changed the title Changed os_auth_pam_pwquality_options type to authtok_type os_auth_pam_pwquality_options: Changed type to authtok_type Mar 23, 2021
@schurzi
Copy link
Contributor

schurzi commented Mar 23, 2021

another nice catch :)
I'll take it like that, because that also seems to be the default from RedHat

@schurzi schurzi merged commit 0f42446 into dev-sec:master Mar 23, 2021
@schurzi schurzi self-assigned this Mar 23, 2021
@schurzi schurzi added the patch label Mar 23, 2021
@joubbi joubbi deleted the authtok_type branch March 24, 2021 06:17
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
os_auth_pam_pwquality_options: Changed type to authtok_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants