Add TLSv1.3 to nginx default configuration #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for missing this PR, @ksaadDE! The PR itself looks good. However the tests fail because we do not have TLSv1.3 in our baseline tests included. I opened a PR for this here: dev-sec/nginx-baseline#51 If this PR is merged, than we can hopefully merge this PR! |
|
Hey @ksaadDE, can you please rebase your PR onto master? Then we can merge it. |
|
Is it rebased now? It's in branch dev-sec:master /E: The dh_params should be updated to 4096. When the merge is done, I can add a PR for it. Just let me know, when done. Ty |
TLSv1.3 should be supported (+security) and soon as possible should be TLSv1.2 EOL.
|
thank you for this contribution :) |
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
Add TLSv1.3 to nginx default configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLSv1.3 should be supported (+security) and soon as possible should be TLSv1.2 EOL.