Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitelist option for yum repository files #487

Merged
merged 1 commit into from Nov 7, 2021

Conversation

darxriggs
Copy link
Contributor

This implements #485.

@rndmh3ro
Copy link
Member

Hey @darxriggs,

thanks for your PR!

Two things:

@darxriggs
Copy link
Contributor Author

Rebase done.

@darxriggs
Copy link
Contributor Author

I will have a look at the tests in the next days.

Files in this whitelist should not be altered.

Currently this is only relevant for enforcing the gpg check.

Signed-off-by: René Scheibe <rene.scheibe@gmail.com>
@darxriggs
Copy link
Contributor Author

I have added a test.

@rndmh3ro
Copy link
Member

rndmh3ro commented Nov 7, 2021

Lgtm!

I'd have preferred to user assert tasks to test the repository files, but this is okay, too.

@rndmh3ro rndmh3ro merged commit bbe4ce1 into dev-sec:master Nov 7, 2021
@darxriggs darxriggs deleted the yum-repository-whitelist branch November 7, 2021 12:31
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
Files in this whitelist should not be altered.

Currently this is only relevant for enforcing the gpg check.

Signed-off-by: René Scheibe <rene.scheibe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants