New dir layout

[rndmh3ro]

This change gets rid of the separate role dir and puts everything into the root-directory, making it possible to install the role via ansible galaxy.

[conorsch]

This is a good change, and should be more intuitive for those just starting to use the role. However, this change doesn't add the ability to install via ansible-galaxy, it simply shortens the include path necessary for playbooks. For example, instead of this:

- name: Lock down OS settings.
  hosts: all:&{{ hosts }}
  sudo: yes
  roles:
    - role: hardening.os-hardening/roles/ansible-os-hardening

you can do this:

- name: Lock down OS settings.
  hosts: all:&{{ hosts }}
  sudo: yes
  roles:
    - role: hardening.os-hardening

Having a roles subdirectory makes sense if there are multiple, related roles bundled together—but that's not the case here, since hardening.ssh-hardening is managed in a separate repo.

[ypid]

• role: hardening.os-hardening/roles/ansible-os-hardening

Sure you can do this if you really want to …

I am more role oriented. I like to have all roles in Ansible’s roles_path and just use them in my playbooks directly.

[conorsch]

@ypid The hardening.os-hardening/roles/ansible-os-hardening path does use the roles_path. If you run ansible-galaxy install hardening.os-hardening, the role will be immediately available for inclusion via the verbose path. With the proposed changes, we could all use the terser hardening.os-hardening, which is a benefit, but galaxy support exists already with the current directory layout.

[ypid]

@conorsch Sure.

[chris-rock]

@rndmh3ro Great simplification @conorsch could you please open an separate issue or PR for your needs?