Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revive old tests with custom ssh settings #491

Merged
merged 9 commits into from Oct 25, 2021
Merged

revive old tests with custom ssh settings #491

merged 9 commits into from Oct 25, 2021

Conversation

rndmh3ro
Copy link
Member

@rndmh3ro rndmh3ro commented Oct 18, 2021

Not sure if this is the best way to test these in the converge-step, yet.

This runs a second scenario with a playbook with custom variables. We only test the converge here, since the baseline-check would fail.

Signed-off-by: rndmh3ro github@gumpri.ch

Signed-off-by: rndmh3ro <github@gumpri.ch>
@rndmh3ro rndmh3ro marked this pull request as draft October 18, 2021 19:07
rndmh3ro added 2 commits October 18, 2021 21:33
Signed-off-by: rndmh3ro <github@gumpri.ch>
Signed-off-by: rndmh3ro <github@gumpri.ch>
rndmh3ro added 3 commits October 18, 2021 21:55
Signed-off-by: rndmh3ro <github@gumpri.ch>
Signed-off-by: rndmh3ro <github@gumpri.ch>
@rndmh3ro rndmh3ro marked this pull request as ready for review October 20, 2021 13:30
Signed-off-by: rndmh3ro <github@gumpri.ch>
Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is verification of this handled? Is our only expectation, that the playbook will fail in converge?

.github/workflows/ssh_hardening_custom_tests.yml Outdated Show resolved Hide resolved
rndmh3ro and others added 2 commits October 25, 2021 10:26
Signed-off-by: rndmh3ro <github@gumpri.ch>
@schurzi schurzi merged commit 12c1f3d into master Oct 25, 2021
@schurzi schurzi deleted the recreate_tests branch October 25, 2021 09:12
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
revive old tests with custom ssh settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants