Only run hardening if /var/log/audit exists #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndmh3ro
reviewed
Jul 13, 2022
|
Also, can you please sign-off your commits? |
Signed-off-by: GitHub <noreply@github.com>
mego22
force-pushed
the
Check_for_var_log_audit
branch
from
a0639a9
to
9d6903e
Compare
Sorry about that, commit signed-off. |
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
This reverts commit c05fe8b. Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
|
Thanks! |
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
* Only run harding if /var/log/audit exists Signed-off-by: GitHub <noreply@github.com> * Update roles/os_hardening/tasks/minimize_access.yml * add more conditionals to when auditd show be hardened Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com> * add more tests to the os-hardening vm tests Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com> * Revert "add more tests to the os-hardening vm tests" This reverts commit c05fe8b. Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com> Co-authored-by: Sebastian Gumprich <rndmh3ro@users.noreply.github.com> Co-authored-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Role os_hardening
Description
We don't run Auditd on our hosts because we have a vendor provides this service for us. Because of this, when #531 was introduced in release 7.15.0 all our builds started failing. Instead for forcing everyone to install Auditd, the hardening step will only be run if
/var/log/auditexists.