Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast expected int types in pam tasks #594

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

dlouzan
Copy link
Contributor

@dlouzan dlouzan commented Oct 27, 2022

馃敡 with 鉂わ笍 by Siemens

Closes #593

@dlouzan
Copy link
Contributor Author

dlouzan commented Oct 27, 2022

@schurzi Would you mind enabling the PR to run the test pipelines? 馃檱

I'm still reviewing the code and our local setup for any other such missing casts in the codebase.

Signed-off-by: Diego Louz谩n <diego.louzan@gmail.com>
@dlouzan dlouzan marked this pull request as ready for review October 27, 2022 14:50
@dlouzan
Copy link
Contributor Author

dlouzan commented Oct 27, 2022

@schurzi Ok so I did not find any other instances of this bug in the codebase, and my local molecule tests passed on fedora35, fedora36 and debian10. Happy to get this in as soon as possible so we can deploy!

@schurzi schurzi changed the title fix(os_hardening): cast expected int types in pam tasks cast expected int types in pam tasks Oct 27, 2022
@schurzi schurzi merged commit 99fe8b6 into dev-sec:master Oct 27, 2022
@schurzi
Copy link
Contributor

schurzi commented Oct 27, 2022

thank you :)

@dlouzan
Copy link
Contributor Author

dlouzan commented Oct 27, 2022

@schurzi Thank you again for the project. I've seen that the changelog has been recently updated to 8.3.0, though there's still no tag. Any chance this will make the cut and the release will happen soon? It's basically blocking a big refactoring of our playbooks 馃樃

@schurzi
Copy link
Contributor

schurzi commented Oct 27, 2022

the tag takes some time, since the release action needs to run ;)
All should be set now, since the action has finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

os_auth_retries variable causes a comparison type error on pam tasks
2 participants