Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify MySQL queries for user deletion #641

Merged
merged 13 commits into from
Mar 1, 2023
Merged

simplify MySQL queries for user deletion #641

merged 13 commits into from
Mar 1, 2023

Commits on Feb 23, 2023

  1. use rowcount to determine mysql results 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    b6171cf View commit details
    Browse the repository at this point in the history

  2. use correct list level 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    0ff7632 View commit details
    Browse the repository at this point in the history

  3. remove json_query 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    96756c9 View commit details
    Browse the repository at this point in the history

  4. remove intermediate vars 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    5587b8b View commit details
    Browse the repository at this point in the history

  5. add check for count 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    6286011 View commit details
    Browse the repository at this point in the history

  6. drop condition, since one result must exist 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    8a90fb2 View commit details
    Browse the repository at this point in the history

  7. move rowcount in condition 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    06687d7 View commit details
    Browse the repository at this point in the history

  8. do loop in ansible to report each deleted user 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    aabe620 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2023

  1. add idempotency check 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    47c771c View commit details
    Browse the repository at this point in the history

  2. additional tests to verify user deletion 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    49fd6b0 View commit details
    Browse the repository at this point in the history

  3. actually iterate the whole user list when deleting 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    bb44772 View commit details
    Browse the repository at this point in the history

  4. fix tests for SuSE 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 24, 2023
    Configuration menu
    Copy the full SHA
    5afff3d View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. adopt suggestions 

    Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
    @schurzi
    schurzi committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    7fbb913 View commit details
    Browse the repository at this point in the history