auditd: add possibility to override config template #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 13, 2023 10:37
by referencing the auditd.conf.j2 template, a custom template can be provided to the role. Signed-off-by: Dennis Lerch <dennis.lerch@mercedes-benz.com>
make freq and log_file configurable implement write_logs with it's default value in order to be able to disable log writing Signed-off-by: Dennis Lerch <dennis.lerch@mercedes-benz.com>
rndmh3ro
reviewed
Jul 22, 2023
There was a problem hiding this comment.
LGTM!
Can you please document the new variables in the README (https://github.com/dev-sec/ansible-collection-hardening/blob/master/roles/os_hardening/README.md)?
|
README.md updated |
|
lgtm! One last thing: could you please sign-off your commits? See: https://github.com/dev-sec/ansible-collection-hardening/pull/685/checks?check_run_id=15261278521 Thanks! |
reorder `os_auditd_log_format` to keep sequence from defaults Signed-off-by: Dennis Lerch <dennis.lerch@mercedes-benz.com>
sure, sorry for the inconvenience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By referencing the
auditd.conf.j2template source, atemplatesdirectory can be created next to your playbook with a custommyauditd.conf.j2template in it.Afterwards you just have to set the variable
os_auditd_templateto myauditd.conf.j2 and the custom template is used.This PR also extend the
auditd.conf.j2bywith its default values set.
Dennis Lerch dennis.lerch@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, Provider Information