Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add role argument spec for os, ssh, mysql #687

Merged
merged 18 commits into from Aug 7, 2023
Merged

add role argument spec for os, ssh, mysql #687

merged 18 commits into from Aug 7, 2023

Conversation

rndmh3ro
Copy link
Member

No description provided.

add role argument spec for os, ssh, mysql
ddfb1fb 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
rndmh3ro and others added 2 commits July 25, 2023 14:11
@rndmh3ro
Merge branch 'master' into arg_spec
e81e832
add role argument spec for os, ssh, mysql
4cb2975 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
Sebastian Gumprich added 6 commits July 31, 2023 14:10
remove variable in variable as it cannot be used in argument spec
a8fb049 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
fix wrong syntax
ce75987
fix spelling errors
7cdfd7e 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
cannot use vars before arg-spec validation
76431dd 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
yamllint the arg-spec
00cb7c4 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
add back variable
a927c77 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
@rndmh3ro rndmh3ro requested a review from schurzi July 31, 2023 14:10
@rndmh3ro rndmh3ro marked this pull request as ready for review July 31, 2023 14:10
schurzi
schurzi requested changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@schurzi schurzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the argument spec is an additional check introduced with newer Ansible versions. So we will not need to raise our minimum version requirements.

roles/mysql_hardening/vars/Debian.yml Outdated Show resolved Hide resolved
molecule/ssh_hardening_custom_tests/converge.yml Outdated Show resolved Hide resolved
roles/mysql_hardening/README.md Show resolved Hide resolved
roles/mysql_hardening/README.md Outdated Show resolved Hide resolved
roles/mysql_hardening/README.md Outdated Show resolved Hide resolved
roles/ssh_hardening/README.md Outdated Show resolved Hide resolved
roles/ssh_hardening/README.md Outdated Show resolved Hide resolved
roles/ssh_hardening/meta/argument_specs.yml Outdated Show resolved Hide resolved
roles/os_hardening/README.md Outdated Show resolved Hide resolved
roles/os_hardening/meta/argument_specs.yml Outdated Show resolved Hide resolved
@rndmh3ro rndmh3ro added the breaking Backwards incompatible change label Aug 2, 2023
Sebastian Gumprich added 9 commits August 2, 2023 13:01
remove redundant setting in tests
6dbc14d
fix descriptions in mysql hardening to betterreflect what they do
224be17 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
remove duplicate empty line
8fecb67 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
set correct defaults on to ssl options
da25e68 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
remove left-over hidepid argument spec
1e326cd 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
remove license and author infos, this lives in the collection readme
90a4130 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
fix styling
2cf3f9f 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
update some descriptions and sort them in the readme
f26d67a 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
some more linting
b76618c 
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
@rndmh3ro rndmh3ro requested a review from schurzi August 4, 2023 07:24
@rndmh3ro rndmh3ro merged commit f295397 into master Aug 7, 2023
58 of 84 checks passed
@rndmh3ro rndmh3ro deleted the arg_spec branch August 7, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schurzi schurzi schurzi approved these changes

Assignees
No one assigned
Labels
breaking Backwards incompatible change enhancement minor mysql_hardening nginx_hardening os_hardening ssh_hardening
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rndmh3ro @schurzi