Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports selectively overriding net.ipv4.ip_forward sysctl var #70

Closed
wants to merge 1 commit into from
Closed

Supports selectively overriding net.ipv4.ip_forward sysctl var #70

wants to merge 1 commit into from

Conversation

conorsch
Copy link
Contributor

The README previously documented a non-existent default var called os_network_forwarding. This commit adds it back, with documentation. The goal is to support selectively overriding only a single sysctl var, that which permits IPv4 forwarding. Presumably this is the most commonly overridden sysctl var for this role—see #50 for discussion.

This commit simply adds sugar to the outstanding #67. @fitz123, feel free to chime in if this is useful for you too.

The README previously documented a non-existent default var
`os_network_forwarding`. This commit readds it to support selectively
overriding only a single sysctl var, that which permits IPv4 forwarding.
@rndmh3ro
Copy link
Member

rndmh3ro commented Feb 1, 2016

I purposefully left that out, because now you have a variable that sets another variable, which is kind of redundant.
Then one could ask the question why only the ipv4.ip_forward variable gets a special treatment and not the others. (See #50, the option "use something like this" on why not to do this)

The way it currently is you have documentation for every variable next to it and can change it as desired, without another abstraction.

@fitz123
Copy link
Contributor

fitz123 commented Feb 1, 2016

I'm doubt) I need overwrite ipv4.ip_forward, but since sysctl dict is in defaults, it's easier to have own dict with all variables you need and from time to time (when ansible hardening framework updated) compare what's new in there. for example, forwarding in my specific case is needed only for firewalls/routers/vpn servers and they're kind of special guys comparing with usual serves (so anyway need changes to sysctl)

otherwise you will just end up with separate variable for each sysctl dict value, and it already has been discussed a lot and community conclusion is keep it as a dict.

@conorsch
Copy link
Contributor Author

conorsch commented Feb 1, 2016

Roger that, let's stick with #67 to solve the problem.

@conorsch conorsch closed this Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants