Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian 8 support #88

Merged
merged 1 commit into from Jun 28, 2016
Merged

debian 8 support #88

merged 1 commit into from Jun 28, 2016

Conversation

rndmh3ro
Copy link
Member

@rndmh3ro rndmh3ro commented Jun 8, 2016

I implemented Debian 8 support (and removed debian 6 support, since its EOL) as well as making it easier to locally test the role with inspec.

I implemented Debian 8 support (and removed debian 6 support, since its
EOL) as well as making it easier to locally test the role with inspec.
@conorsch
Copy link
Contributor

There are a few sysctl values that aren't explicitly defined in the role, yet are tested for. At least under Debian, the assumption causes tests to fail:

Finished in 2.51 seconds (files took 6 minutes 41 seconds to load)
99 examples, 18 failures

Failed examples:

rspec  # Kernel Parameter net.ipv4.conf.default.accept_source_route value should eq 0
rspec  # Kernel Parameter net.ipv4.conf.default.accept_redirects value should eq 0
rspec  # Kernel Parameter net.ipv4.conf.all.accept_redirects value should eq 0
rspec  # Kernel Parameter net.ipv4.conf.all.secure_redirects value should eq 0
rspec  # Kernel Parameter net.ipv4.conf.default.secure_redirects value should eq 0
rspec  # Kernel Parameter net.ipv4.conf.all.send_redirects value should eq 0
rspec  # Kernel Parameter net.ipv4.conf.all.send_redirects value should eq 0
rspec  # Kernel Parameter net.ipv4.conf.all.log_martians value should eq 1
rspec  # Kernel Parameter net.ipv6.conf.default.accept_redirects value should eq 0
rspec  # Kernel Parameter net.ipv6.conf.all.accept_redirects value should eq 0
rspec  # Kernel Parameter net.ipv6.conf.default.router_solicitations value should eq 0
rspec  # Kernel Parameter net.ipv6.conf.default.accept_ra_rtr_pref value should eq 0
rspec  # Kernel Parameter net.ipv6.conf.default.accept_ra_pinfo value should eq 0
rspec  # Kernel Parameter net.ipv6.conf.default.accept_ra_defrtr value should eq 0
rspec  # Kernel Parameter net.ipv6.conf.default.autoconf value should eq 0
rspec  # Kernel Parameter net.ipv6.conf.default.dad_transmits value should eq 0
rspec  # Kernel Parameter net.ipv6.conf.default.max_addresses value should eq 1
rspec  # Kernel Parameter kernel.sysrq value should eq 0

>>>>>> Verify failed on instance <os-ansible-latest-debian-8>.
>>>>>> Please see .kitchen/logs/os-ansible-latest-debian-8.log for more details
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: Inspec Runner returns 1

The inspec profiles do load correctly, however, which is grand. Since this PR only modifies the testing setup, +1 for merge. We can continue to debug the test suite for all platforms going forward, and we don't need to worry about config regressions from merging these test-only changes.

@rndmh3ro
Copy link
Member Author

Yes, these are right now to be expected and have nothing to do with Debian itself.
I will fix them later.

@conorsch
Copy link
Contributor

👍 :shipit:

@rndmh3ro rndmh3ro merged commit f059577 into master Jun 28, 2016
@rndmh3ro rndmh3ro deleted the debian8 branch August 3, 2016 17:09
rndmh3ro added a commit that referenced this pull request Jul 24, 2020
use centos 7 in vagrant, limit ssh conns
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
use centos 7 in vagrant, limit ssh conns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants