Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amazon Linux 2 AuditD issue #271

Merged
merged 11 commits into from
Mar 23, 2021
Merged

Amazon Linux 2 AuditD issue #271

merged 11 commits into from
Mar 23, 2021

Conversation

mfortin
Copy link
Contributor

@mfortin mfortin commented Mar 19, 2021

Resolving issue #270
Resolving some issues in regards to test kitchen expecting a different set of permissions on crontab owned files and directories.

Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
Signed-off-by: Math Fortin <mathieu@fortin.info>
Signed-off-by: Math Fortin <mathieu@fortin.info>
Signed-off-by: Math Fortin <mathieu@fortin.info>
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mfortin Thank you for your contribution 💯 I added a few questions...

metadata.rb Outdated Show resolved Hide resolved
recipes/auditd.rb Show resolved Hide resolved
recipes/minimize_access.rb Outdated Show resolved Hide resolved
Signed-off-by: Math Fortin <mathieu@fortin.info>
@mfortin
Copy link
Contributor Author

mfortin commented Mar 22, 2021

hi @chris-rock, replied to your questions!

@mfortin
Copy link
Contributor Author

mfortin commented Mar 22, 2021

Signed-off-by: Math Fortin <mathieu@fortin.info>
Signed-off-by: Math Fortin <mathieu@fortin.info>
Signed-off-by: Math Fortin <mathieu@fortin.info>
Signed-off-by: Math Fortin <mathieu@fortin.info>
@mfortin
Copy link
Contributor Author

mfortin commented Mar 22, 2021

@chris-rock builds are failing because of an updated dependency. See here github-changelog-generator/github-changelog-generator#942. Waiting on resolution.

Signed-off-by: Mathieu Fortin <mathieu.fortin@autodesk.com>
@mfortin mfortin requested a review from chris-rock March 22, 2021 19:20
@mfortin mfortin closed this Mar 22, 2021
@mfortin mfortin reopened this Mar 22, 2021
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the addition @mfortin

@chris-rock chris-rock merged commit 2a17eba into dev-sec:master Mar 23, 2021
@mfortin
Copy link
Contributor Author

mfortin commented Mar 23, 2021

@chris-rock now, who do I bug to get a new release ? 😏

@mfortin mfortin deleted the issue-270 branch March 23, 2021 11:25
@chris-rock
Copy link
Member

@mfortin I am with you. I think we need to get the pipeline green before we can actually release. I am pretty packed, any help to get us there is appreciated.

@dev-sec-bot dev-sec-bot mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants