Skip to content

Commit

Permalink
Merge pull request #5 from atomic111/master
Browse files Browse the repository at this point in the history
remove aes-gcm algos from Ciphers, because of http://www.openssh.com/txt/gcmrekey.adv
  • Loading branch information
chris-rock committed May 7, 2014
2 parents 1b01ae4 + 660031c commit 076434e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion templates/default/opensshd.conf.erb
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ LogLevel VERBOSE
# eg ruby Net::SSH::Transport::CipherFactory requires cbc-versions of the given openssh ciphers to work
# -- see: (http://net-ssh.github.com/net-ssh/classes/Net/SSH/Transport/CipherFactory.html)
#
Ciphers aes256-gcm@openssh.com,aes128-gcm@openssh.com,aes128-ctr,aes256-ctr,aes192-ctr<% if @node['ssh']['cbc_required'] == true %>,aes128-cbc,aes256-cbc,aes192-cbc<% end %>
Ciphers aes128-ctr,aes256-ctr,aes192-ctr<% if @node['ssh']['cbc_required'] == true %>,aes128-cbc,aes256-cbc,aes192-cbc<% end %>

# **Hash algorithms** -- Make sure not to use SHA1 for hashing, unless it is really necessary.
# Weak HMAC is sometimes required if older package versions are used
Expand Down
4 changes: 2 additions & 2 deletions test/integration/default/serverspec/ssh_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
end

describe file('/etc/ssh/sshd_config') do
its(:content) { should match /^Ciphers (aes256-gcm@openssh.com,aes128-gcm@openssh.com,aes128-ctr,aes256-ctr,aes192-ctr)|(aes256-gcm@openssh.com,aes128-gcm@openssh.com,aes128-ctr,aes256-ctr,aes192-ctr,aes128-cbc,aes256-cbc,aes192-cbc)$/}
its(:content) { should match /^Ciphers (aes128-ctr,aes256-ctr,aes192-ctr)|(aes128-ctr,aes256-ctr,aes192-ctr,aes128-cbc,aes256-cbc,aes192-cbc)$/}
end

describe file('/etc/ssh/sshd_config') do
Expand Down Expand Up @@ -390,4 +390,4 @@
its(:content) { should match /^#VisualHostKey yes$/}
end

end
end

0 comments on commit 076434e

Please sign in to comment.