Configuration of root keys via databag and attributes #37

Closed
chris-rock opened this Issue Sep 5, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@chris-rock
Member

chris-rock commented Sep 5, 2014

The current version uses databags only:
https://github.com/TelekomLabs/chef-ssh-hardening/blob/master/recipes/server.rb#L74-L79

We should support databags and attributes and merge the the keys. Simple flags should enable users to deactivate databag or attributes usage.

Thanks @bkw for reporting this.

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Sep 5, 2014

Contributor

Actually, I'm fine with just supporting data bags. The thing that bit me was that the recipe insists on the databag to exist (although it is perfectly fine with an empty data bag).
That's why I always have to do a "mkdir data_bags/users" prior to runnning my chefspec tests.
Wrapping the access to the data bag into a check whether such a data bag exists would be enough for me.

Contributor

bkw commented Sep 5, 2014

Actually, I'm fine with just supporting data bags. The thing that bit me was that the recipe insists on the databag to exist (although it is perfectly fine with an empty data bag).
That's why I always have to do a "mkdir data_bags/users" prior to runnning my chefspec tests.
Wrapping the access to the data bag into a check whether such a data bag exists would be enough for me.

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 14, 2014

Contributor

... and I somehow feel that a PR for just that is about to hit an inbox near you very soon. But now for some sleep...

Contributor

bkw commented Oct 14, 2014

... and I somehow feel that a PR for just that is about to hit an inbox near you very soon. But now for some sleep...

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 14, 2014

Member

fixed with #50

Member

chris-rock commented Oct 14, 2014

fixed with #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment