make users data bag optional #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that looks very good. It improves the overall usability of the cookbook. +1 @bkw |
chris-rock
added a commit
that referenced
this pull request
Oct 14, 2014
make users data bag optional
|
thanks. I'll have to rebase #49 now, give me a minute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been bugging me for some time (see comments in #37 and #16 ): The cookbook raises an error if there is no data bag
userson the server - which is a perfectly valid scenario: I only want to harden my servers, not install users.This pr fixes that. A non-existing users data bag is treated like an empty one.
As a side effect, this makes a lot of the server tests more concise, since we can avoid stubbing the unused bag.