make users data bag optional #50

Merged
merged 4 commits into from Oct 14, 2014

Conversation

Projects
None yet
3 participants
@bkw
Contributor

bkw commented Oct 14, 2014

This has been bugging me for some time (see comments in #37 and #16 ): The cookbook raises an error if there is no data bag users on the server - which is a perfectly valid scenario: I only want to harden my servers, not install users.

This pr fixes that. A non-existing users data bag is treated like an empty one.

As a side effect, this makes a lot of the server tests more concise, since we can avoid stubbing the unused bag.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 14, 2014

Coverage Status

Coverage remained the same when pulling e5bedea on bkw:databagOptional into e288bc4 on TelekomLabs:master.

Coverage Status

Coverage remained the same when pulling e5bedea on bkw:databagOptional into e288bc4 on TelekomLabs:master.

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 14, 2014

Member

that looks very good. It improves the overall usability of the cookbook. +1 @bkw

Member

chris-rock commented Oct 14, 2014

that looks very good. It improves the overall usability of the cookbook. +1 @bkw

chris-rock added a commit that referenced this pull request Oct 14, 2014

Merge pull request #50 from bkw/databagOptional
make users data bag optional

@chris-rock chris-rock merged commit 7bccda5 into dev-sec:master Oct 14, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 14, 2014

Contributor

thanks. I'll have to rebase #49 now, give me a minute.

Contributor

bkw commented Oct 14, 2014

thanks. I'll have to rebase #49 now, give me a minute.

@bkw bkw deleted the bkw:databagOptional branch Oct 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment