Deprecate managing authorized_keys for root via data bag #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is great. In addition I think we need to add an example that show the interoperability with the users cookbook |
|
Do we really need to have an example for interoperability? Once we removed support, we don't touch authorized_keys anymore and so there is no interaction or interoperability left, right? I'd rather avoid having to document other cookbooks behaviors in here and keep up with their changes. |
bkw
force-pushed
the
deprecateRootKeys
branch
from
24b1ff1
to
5bf84a9
Compare
|
rebased to current master. |
chris-rock
added a commit
that referenced
this pull request
Oct 14, 2014
Deprecate managing authorized_keys for root via data bag
|
thx @bkw |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #16 and #37, we should keep our concerns separated and not manage users or credentials in this cookbook.
This PR displays a warning when a users data bag with ssh_rootkey or ssh_rootkeys is found. The old behavior has not been changed, but I think we agree that it should be removed in 2.x.