New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate managing authorized_keys for root via data bag #52

Merged
merged 2 commits into from Oct 14, 2014

Conversation

Projects
None yet
3 participants
@bkw
Contributor

bkw commented Oct 14, 2014

As discussed in #16 and #37, we should keep our concerns separated and not manage users or credentials in this cookbook.

This PR displays a warning when a users data bag with ssh_rootkey or ssh_rootkeys is found. The old behavior has not been changed, but I think we agree that it should be removed in 2.x.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 14, 2014

Coverage Status

Coverage remained the same when pulling 24b1ff1 on bkw:deprecateRootKeys into 7bccda5 on TelekomLabs:master.

coveralls commented Oct 14, 2014

Coverage Status

Coverage remained the same when pulling 24b1ff1 on bkw:deprecateRootKeys into 7bccda5 on TelekomLabs:master.

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Oct 14, 2014

Member

this is great. In addition I think we need to add an example that show the interoperability with the users cookbook

Member

chris-rock commented Oct 14, 2014

this is great. In addition I think we need to add an example that show the interoperability with the users cookbook

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 14, 2014

Contributor

Do we really need to have an example for interoperability?

Once we removed support, we don't touch authorized_keys anymore and so there is no interaction or interoperability left, right? I'd rather avoid having to document other cookbooks behaviors in here and keep up with their changes.

Separate all the concerns!

Contributor

bkw commented Oct 14, 2014

Do we really need to have an example for interoperability?

Once we removed support, we don't touch authorized_keys anymore and so there is no interaction or interoperability left, right? I'd rather avoid having to document other cookbooks behaviors in here and keep up with their changes.

Separate all the concerns!

@bkw bkw referenced this pull request Oct 14, 2014

Closed

bring back support for chef-solo #1

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock
Member

chris-rock commented Oct 14, 2014

#55

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 14, 2014

Coverage Status

Coverage remained the same when pulling 5bf84a9 on bkw:deprecateRootKeys into 2f9e415 on TelekomLabs:master.

coveralls commented Oct 14, 2014

Coverage Status

Coverage remained the same when pulling 5bf84a9 on bkw:deprecateRootKeys into 2f9e415 on TelekomLabs:master.

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 14, 2014

Contributor

rebased to current master.

Contributor

bkw commented Oct 14, 2014

rebased to current master.

chris-rock added a commit that referenced this pull request Oct 14, 2014

Merge pull request #52 from bkw/deprecateRootKeys
Deprecate managing authorized_keys for root via data bag

@chris-rock chris-rock merged commit 574f997 into dev-sec:master Oct 14, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock
Member

chris-rock commented Oct 14, 2014

thx @bkw

@bkw

This comment has been minimized.

Show comment
Hide comment
@bkw

bkw Oct 14, 2014

Contributor

thanks!

Contributor

bkw commented Oct 14, 2014

thanks!

@bkw bkw deleted the bkw:deprecateRootKeys branch Oct 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment