Some tests for attributes of last merged PRs #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-sidorenko
force-pushed
the
tests
branch
from
7ea7034
to
d2f18d1
Compare
|
Great addition @artem-sidorenko Should we add tests for our automatic detection as well? |
|
@chris-rock automatic detection? Do you mean the ssh version, crypto parameters or something else? We have the tests for ssh version and for crypto parameters |
artem-sidorenko
added a commit
to artem-forks/chef-ssh-hardening
that referenced
this pull request
Dec 23, 2016
Due to the parallel merge of dev-secGH-151 and dev-secGH-150
Merged
artem-sidorenko
added a commit
to artem-forks/chef-ssh-hardening
that referenced
this pull request
Dec 23, 2016
Due to the parallel merge of dev-secGH-151 and dev-secGH-150
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.