New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send and Accept locale environment variables #167

Merged
merged 1 commit into from Feb 2, 2017

Conversation

Projects
None yet
3 participants
@mikemoate
Member

mikemoate commented Jan 31, 2017

Fixes #160

@mikemoate mikemoate requested a review from artem-sidorenko Jan 31, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 31, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 0632a9a on mikemoate:issue_160_locale into b882cdd on dev-sec:master.

coveralls commented Jan 31, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 0632a9a on mikemoate:issue_160_locale into b882cdd on dev-sec:master.

@mikemoate

This comment has been minimized.

Show comment
Hide comment
@mikemoate

mikemoate Jan 31, 2017

Member

@artem-sidorenko tests seem to fail on Oracle only, I'm not sure why, and I can't see how to view the specific failures in Travis?

Member

mikemoate commented Jan 31, 2017

@artem-sidorenko tests seem to fail on Oracle only, I'm not sure why, and I can't see how to view the specific failures in Travis?

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Jan 31, 2017

Member

@mikemoate you just click the failed job and can see the log: https://travis-ci.org/dev-sec/chef-ssh-hardening/jobs/196915943

I looks totally unrelated to your changes and actually looks like master should be also broken. I will have a look

Member

artem-sidorenko commented Jan 31, 2017

@mikemoate you just click the failed job and can see the log: https://travis-ci.org/dev-sec/chef-ssh-hardening/jobs/196915943

I looks totally unrelated to your changes and actually looks like master should be also broken. I will have a look

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Jan 31, 2017

Member

it looks like this is related to the fix within train: inspec/train@6b5d582

We have to add oracle platform to the ssh-baseline, I'll create a PR

Member

artem-sidorenko commented Jan 31, 2017

it looks like this is related to the fix within train: inspec/train@6b5d582

We have to add oracle platform to the ssh-baseline, I'll create a PR

@mikemoate

This comment has been minimized.

Show comment
Hide comment
@mikemoate

mikemoate Jan 31, 2017

Member

OK thanks. I could see the Travis logs but not the details of the failing test cases.

Now I realise they are just very un-obvious (compared to the test passed lines which are highlighted red), maybe I'll give TravisCI some feedback :-)

Member

mikemoate commented Jan 31, 2017

OK thanks. I could see the Travis logs but not the details of the failing test cases.

Now I realise they are just very un-obvious (compared to the test passed lines which are highlighted red), maybe I'll give TravisCI some feedback :-)

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Jan 31, 2017

Member

@mikemoate I guess this color problem is related somehow to the bash-color done by inspec. Usually it looks properly

Member

artem-sidorenko commented Jan 31, 2017

@mikemoate I guess this color problem is related somehow to the bash-color done by inspec. Usually it looks properly

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko
Member

artem-sidorenko commented Jan 31, 2017

@mikemoate the dev-sec/ssh-baseline#80 should fix the tests

Show outdated Hide outdated templates/default/openssh.conf.erb
Show outdated Hide outdated templates/default/opensshd.conf.erb
Show outdated Hide outdated spec/recipes/server_spec.rb
@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Jan 31, 2017

Member

Thank you for this PR! I've added some comments:)

Member

artem-sidorenko commented Jan 31, 2017

Thank you for this PR! I've added some comments:)

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 1, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling a9adb7d on mikemoate:issue_160_locale into b882cdd on dev-sec:master.

coveralls commented Feb 1, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling a9adb7d on mikemoate:issue_160_locale into b882cdd on dev-sec:master.

@mikemoate

This comment has been minimized.

Show comment
Hide comment
@mikemoate

mikemoate Feb 1, 2017

Member

@artem-sidorenko I think this covers everything you asked for now.

Member

mikemoate commented Feb 1, 2017

@artem-sidorenko I think this covers everything you asked for now.

@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko

artem-sidorenko Feb 2, 2017

Member

@mikemoate looks good to me, could you please also cleanup the commit history by squashing the commits?

Member

artem-sidorenko commented Feb 2, 2017

@mikemoate looks good to me, could you please also cleanup the commit history by squashing the commits?

Mike Moate
Send and Accept locale environment variables
Use attributes to set the environment variables that ssh client should send and that ssh daemon should accept.
The primary use case here is for locale, and the default attribute value reflects this (as discussed in #160).

Chefspec tests cover the default, custom/overriden and empty cases for the attributes.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 2, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d5d7ea6 on mikemoate:issue_160_locale into b882cdd on dev-sec:master.

coveralls commented Feb 2, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling d5d7ea6 on mikemoate:issue_160_locale into b882cdd on dev-sec:master.

@mikemoate

This comment has been minimized.

Show comment
Hide comment
@mikemoate

mikemoate Feb 2, 2017

Member

@artem-sidorenko squashed as requested.

Member

mikemoate commented Feb 2, 2017

@artem-sidorenko squashed as requested.

@artem-sidorenko artem-sidorenko merged commit 41d98b3 into dev-sec:master Feb 2, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@artem-sidorenko

This comment has been minimized.

Show comment
Hide comment
@artem-sidorenko
Member

artem-sidorenko commented Feb 2, 2017

@mikemoate thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment