New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding attributes to enable printing the MOTD. #71

Merged
merged 3 commits into from Feb 16, 2015

Conversation

Projects
None yet
3 participants
@dmerrick
Contributor

dmerrick commented Jan 29, 2015

We like having a MOTD, so I added these attributes to enable support for that.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Jan 29, 2015

Coverage Status

Coverage remained the same at 93.23% when pulling d996705 on IFTTT:adding_attributes_to_enable_motd into e071016 on TelekomLabs:master.

coveralls commented Jan 29, 2015

Coverage Status

Coverage remained the same at 93.23% when pulling d996705 on IFTTT:adding_attributes_to_enable_motd into e071016 on TelekomLabs:master.

@dmerrick

This comment has been minimized.

Show comment
Hide comment
@dmerrick

dmerrick Jan 29, 2015

Contributor

Not sure why it failed the specs. Let me know if I can do anything to improve it!

Contributor

dmerrick commented Jan 29, 2015

Not sure why it failed the specs. Let me know if I can do anything to improve it!

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Jan 30, 2015

Member

@dmerrick great work. Thanks for adding these options. One small improvement would be to add some test to ChefSpec: https://github.com/TelekomLabs/chef-ssh-hardening/blob/master/spec/recipes/server_spec.rb

I will have a look into the travis issues.

Member

chris-rock commented Jan 30, 2015

@dmerrick great work. Thanks for adding these options. One small improvement would be to add some test to ChefSpec: https://github.com/TelekomLabs/chef-ssh-hardening/blob/master/spec/recipes/server_spec.rb

I will have a look into the travis issues.

@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Feb 6, 2015

Member

@dmerrick could you rebase please? we fixed the tests in travis. Therefore everything should work now.

Member

chris-rock commented Feb 6, 2015

@dmerrick could you rebase please? we fixed the tests in travis. Therefore everything should work now.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 10, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling a49e0da on IFTTT:adding_attributes_to_enable_motd into 31b8fb7 on TelekomLabs:master.

coveralls commented Feb 10, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling a49e0da on IFTTT:adding_attributes_to_enable_motd into 31b8fb7 on TelekomLabs:master.

chris-rock added a commit that referenced this pull request Feb 16, 2015

Merge pull request #71 from IFTTT/adding_attributes_to_enable_motd
Adding attributes to enable printing the MOTD.

@chris-rock chris-rock merged commit 5afc4c9 into dev-sec:master Feb 16, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@chris-rock

This comment has been minimized.

Show comment
Hide comment
@chris-rock

chris-rock Feb 16, 2015

Member

@dmerrick Thank you very much!

Member

chris-rock commented Feb 16, 2015

@dmerrick Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment