Adding attributes to enable printing the MOTD. #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why it failed the specs. Let me know if I can do anything to improve it! |
|
@dmerrick great work. Thanks for adding these options. One small improvement would be to add some test to ChefSpec: https://github.com/TelekomLabs/chef-ssh-hardening/blob/master/spec/recipes/server_spec.rb I will have a look into the travis issues. |
|
@dmerrick could you rebase please? we fixed the tests in travis. Therefore everything should work now. |
dmerrick
force-pushed
the
adding_attributes_to_enable_motd
branch
from
d996705
to
5192863
Compare
added 2 commits
February 9, 2015 11:57
Personally, I think files should end in newlines, and I thought Rubocop would enforce this...
chris-rock
added a commit
that referenced
this pull request
Feb 16, 2015
Adding attributes to enable printing the MOTD.
|
@dmerrick Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We like having a MOTD, so I added these attributes to enable support for that.