Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation Warnings #115

Closed
mcgege opened this issue May 29, 2019 · 4 comments
Closed

Deprecation Warnings #115

mcgege opened this issue May 29, 2019 · 4 comments

Comments

@mcgege
Copy link
Member

mcgege commented May 29, 2019

I see these warning messages in kitchen-inspec tests of puppet-os-hardening:

WARN: DEPRECATION: The 'default' option for attributes is being replaced by 'value' - please use it instead. attribute name: 'Inspec::Input' (used at linux-baseline-master/controls/os_spec.rb:20)
WARN: DEPRECATION: The 'default' option for attributes is being replaced by 'value' - please use it instead. attribute name: 'Inspec::Input' (used at linux-baseline-master/controls/os_spec.rb:22)
WARN: DEPRECATION: The 'default' option for attributes is being replaced by 'value' - please use it instead. attribute name: 'Inspec::Input' (used at linux-baseline-master/controls/os_spec.rb:23)
WARN: DEPRECATION: The 'default' option for attributes is being replaced by 'value' - please use it instead. attribute name: 'Inspec::Input' (used at linux-baseline-master/controls/os_spec.rb:24)
WARN: DEPRECATION: The 'default' option for attributes is being replaced by 'value' - please use it instead. attribute name: 'Inspec::Input' (used at linux-baseline-master/controls/os_spec.rb:34)
WARN: DEPRECATION: The 'default' option for attributes is being replaced by 'value' - please use it instead. attribute name: 'Inspec::Input' (used at linux-baseline-master/controls/package_spec.rb:20)
WARN: DEPRECATION: The 'default' option for attributes is being replaced by 'value' - please use it instead. attribute name: 'Inspec::Input' (used at linux-baseline-master/controls/sysctl_spec.rb:20)
WARN: DEPRECATION: The 'default' option for attributes is being replaced by 'value' - please use it instead. attribute name: 'Inspec::Input' (used at linux-baseline-master/controls/sysctl_spec.rb:21)

Inspec: 4.3.2
Kitchen-Inspec: 1.1.0
@mcgege
Copy link
Member Author

mcgege commented May 29, 2019

Can we replace default with value here or do we break something in older Inspec versions?

@chris-rock
Copy link
Member

InSpec started to move of its attributes naming and recently introduced inspec/inspec#3802 Since we want to support older InSpec environments as well, its safe to ignore for now.

@chris-rock
Copy link
Member

In addition, we are not able to officially use InSpec 4 in our CI/CD env yet due to an open question around license agreement. The discussion started in dev-sec/apache-baseline#31.

mcgege added a commit to dev-sec/puppet-os-hardening that referenced this issue May 29, 2019
@mcgege
Stick to Inspec 3.x (see dev-sec/linux-baseline#115)
d4a4f19 
Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege
Copy link
Member Author

mcgege commented May 29, 2019

@chris-rock Thanks for the info ... I'll stick to Inspec version 3 for now, this will also spare me the deprecation warnings ;-)

@mcgege mcgege closed this as completed May 29, 2019
mcgege added a commit to dev-sec/puppet-os-hardening that referenced this issue May 29, 2019
@mcgege
Kitchen / Travis-CI fix (#206)
0ef6927 
* Fix librarian-puppet error
* Remove cleanup parameter (annoying docker error message)
* Fix inspec url warning
* No symlink checks any more (librarian-puppet metadata)
* Stick to Inspec 3.x (see dev-sec/linux-baseline#115)

Signed-off-by: Michael Geiger <info@mgeiger.de>
@mcgege mcgege mentioned this issue Jun 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chris-rock @mcgege