converted module to pdk #107 #120
Conversation
|
Hi @enemarke , thanks a lot for working on this topic ... as I'm not the kitchen guru, maybe @artem-sidorenko can help us here? I also would suggest to separate the functional optimization ( |
Rakefile
Outdated
|
|
||
| task :default => [:run_all_linters, :spec] | ||
|
|
||
| # Changelog Generator |
There was a problem hiding this comment.
I definitely need this one for generating the Changelog
metadata.json
Outdated
| "version_requirement": ">= 4.0.0 < 6.0.0" | ||
| } | ||
| ], | ||
| "template-url": "file:///opt/puppetlabs/pdk/share/cache/pdk-templates.git", |
There was a problem hiding this comment.
Maybe we should change this to https://github.com/puppetlabs/pdk-templates
|
I have made a new commit that removed changes to /lib/, /manifest/ and some in /spec/. I hope this is the correct way for moving changes into a new pull request. The rubocop test is now failing, due to the missing changes in /lib/* and /spec/. |
There was a problem hiding this comment.
@enemarke thanks for this PR! It makes definitely sense
I have two comments:
- please do not remote test-kitchen - we need and use it for integration tests against linux-baseline
- please avoid any big changes to Rakefile/.travis.yml if possible, almost everything there is used and makes sense the way it is. If you would like to introduce changes to the Rakefile/.travis.yml, please lets do it in a dedicated PR to allow easier review
.travis.yml
Outdated
| sudo: false | ||
| dist: trusty |
There was a problem hiding this comment.
this is not needed anymore, its a new default
|
@artem-sidorenko That makes sense. Should I close this pull request and open one or two new ones in order to get fewer cleaner commits or should I just make changes directly to this pull request? |
enemarke
force-pushed
the
master
branch
3 times, most recently
from
e50e357
to
5d1ef4f
Compare
|
I have rebased into fewer commits and removed changes to travis and test-kitchen. |
|
I pushed it for integration tests: https://travis-ci.org/dev-sec/puppet-os-hardening/builds/341803747, it looks good to me. The failing tests are not fixed yet. @enemarke could you maybe squash all other commits to one "pdk" commit? |
|
@enemarke Also looks good to me ... could you please rebase your changes now on top of the master branch so that we could merge it? |
|
Rebasing done. |
|
@enemarke Retested it, looks good ... one final wish: Could you please rewrite your commit message, compact it and remove those comments, that have already been merged before? |
|
@mcgege I have rewritten the commit message. |
|
@enemarke Thanks a lot! |
Hi
I have converted the module to be pdk compliant and made a few minor refactors.
Some notes on what I have brooken and what is missing:
Cheers