Baseline sysctl-17: Enable logging of martian packets #96
Conversation
There was a problem hiding this comment.
@mcgege great! Many thanks!
Maybe we will have to change the defaults later depending on the discussion in dev-sec/linux-baseline#48
@bitvijays looks good to me!
|
@mcgege Thank you for your pull request :) Although the variable name "log_martians" speaks for itself, what are your thoughts if we keep it "enable_log_martians" ? (I might be completely wrong) Just a thought :) may be just to follow the trend? enable_ ? @artem-sidorenko Any thoughts? |
|
@bitvijays Well, I think the variable name should be sufficient to understand what it's all about, but I'm open to change it ... |
|
@mcgege Cool.. Let's change it to enable_log_martians. and this is just to follow the trend of the variables defined above $enable_ipv6 and I will merge the pull request :) |
|
@mcgege You may have to rebase with master to correct the conflict. |
As this feature can produce large log files, it can be disabled via 'log_martians' Signed-off-by: Michael Geiger <michael.geiger@telekom.de>
|
@bitvijays rebase + change done |
|
@mcgege Thank you for the Pull request and your contribution :) Merged |
As this feature can produce large log files, it can be disabled via 'log_martians'
This PR implements sysctl-17 as discussed in dev-sec/linux-baseline#48 and dev-sec/linux-baseline#72 and should fix #66
Signed-off-by: Michael Geiger michael.geiger@telekom.de