-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libraries/windows_updates.rb:18:in `[]': no implicit conversion of String into Integer (TypeError) #13
Comments
I'm getting the same error on Windows 2016 using the windows-patch-baseline profile.
|
found this which may be the fix:
taken from this fork nandeshguru@60f2e6e |
I've confirmed this is still an issue, I'm making a PR to address this today This is what I see when I run the profile on a Windows 2019 box with no patches available: [2020-04-23T06:46:01-07:00] ERROR: Report handler Chef::Handler::AuditReport raised #<TypeError: no implicit conversion of String into Integer>
[2020-04-23T06:46:01-07:00] ERROR: libraries/windows_updates.rb:18:in `[]'
[2020-04-23T06:46:01-07:00] ERROR: libraries/windows_updates.rb:18:in `title'
[2020-04-23T06:46:01-07:00] ERROR: libraries/windows_updates.rb:42:in `to_s'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/rspec-core-3.9.1/lib/rspec/core/metadata.rb:179:in `build_description_from'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/rspec-core-3.9.1/lib/rspec/core/metadata.rb:133:in `populate'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/rspec-core-3.9.1/lib/rspec/core/metadata.rb:257:in `create'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/rspec-core-3.9.1/lib/rspec/core/example_group.rb:422:in `set_it_up'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/rspec-core-3.9.1/lib/rspec/core/example_group.rb:386:in `subclass'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/rspec-core-3.9.1/lib/rspec/core/example_group.rb:260:in `block in define_example_group_method'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-4.18.104/lib/inspec/runner_rspec.rb:28:in `example_group'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-4.18.104/lib/inspec/runner.rb:312:in `add_resource'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-4.18.104/lib/inspec/runner.rb:276:in `get_check_example'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-4.18.104/lib/inspec/runner.rb:284:in `block in register_rule'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-4.18.104/lib/inspec/runner.rb:283:in `each'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-4.18.104/lib/inspec/runner.rb:283:in `flat_map'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-4.18.104/lib/inspec/runner.rb:283:in `register_rule'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-4.18.104/lib/inspec/runner.rb:123:in `block in load'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-4.18.104/lib/inspec/runner.rb:122:in `each'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-4.18.104/lib/inspec/runner.rb:122:in `load'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/inspec-core-4.18.104/lib/inspec/runner.rb:129:in `run'
[2020-04-23T06:46:01-07:00] ERROR: c:/chef/cache/cookbooks/audit/files/default/handler/audit_report.rb:183:in `call'
[2020-04-23T06:46:01-07:00] ERROR: c:/chef/cache/cookbooks/audit/files/default/handler/audit_report.rb:82:in `report'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/handler.rb:256:in `run_report_unsafe'
[2020-04-23T06:46:01-07:00] ERROR: c:/chef/cache/cookbooks/audit/files/default/handler/audit_report.rb:100:in `run_report_safely'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/handler.rb:123:in `block in run_report_handlers'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/handler.rb:121:in `each'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/handler.rb:121:in `run_report_handlers'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/handler.rb:133:in `block in <class:Handler>'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/client.rb:426:in `block in run_completed_successfully'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/client.rb:425:in `each'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/client.rb:425:in `run_completed_successfully'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/client.rb:292:in `run'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/application.rb:320:in `run_with_graceful_exit_option'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/application.rb:296:in `block in run_chef_client'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/local_mode.rb:42:in `with_server_connectivity'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/application.rb:279:in `run_chef_client'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/application/base.rb:330:in `run_application'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-15.10.12-universal-mingw32/lib/chef/application.rb:68:in `run'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/embedded/lib/ruby/gems/2.6.0/gems/chef-bin-15.10.12/bin/chef-client:25:in `<top (required)>'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/bin/chef-client:194:in `load'
[2020-04-23T06:46:01-07:00] ERROR: C:/opscode/chef/bin/chef-client:194:in `<main>'
- Chef::Handler::AuditReport
Running handlers complete
Chef Infra Client finished, 0/2 resources updated in 24 seconds I need to test on other versions of Windows to make sure the fix works for 2012, 2016 and Windows 10 |
well I can't actually get it to error out reliably, can anyone share more specific circumstances in which this occurs? |
I'm running latest version of chef 15 and latest audit coobook with this profile set in the attributes. Instance is a Windows 2016 machine running on AWS ec2. Instance is standard windows image from marketplace. Is there any other specific info you're looking for? |
Here's the attributes I'm overriding from defaults in the audit cookbook:
|
Just to add my voice to the pile: this does not appear to fix the issue in the case when there are no patches available. |
@rndmh3ro @chris-rock I was wondering if you guys may be able to help us on this one. |
should be fixed by #26 if you still have problems, please comment |
Describe the bug
baseline scans works fine on Windows 2012 which is unsupported. But fails on Windows 2012 R2 with the following error.
The text was updated successfully, but these errors were encountered: