Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android:exported attribute to AndroidManifest #13

Merged
merged 2 commits into from
May 23, 2021
Merged

Add android:exported attribute to AndroidManifest #13

merged 2 commits into from
May 23, 2021

Conversation

sebastinto
Copy link
Contributor

@sebastinto sebastinto commented May 22, 2021

I believe I am getting Manifest Merger errors because of the missing attribute in this lib.

Please see Android Dev documentation:

If your app targets Android 12 and contains activities, services, or broadcast receivers that use intent filters, you must explicitly declare the android:exported attribute for these app components.

I set the attribute to "true" in this PR but setting it to "false" would also fix compatibility with Android 12.

@deva666
Copy link
Owner

deva666 commented May 23, 2021

Thanks!

@deva666 deva666 merged commit 71dfa88 into deva666:master May 23, 2021
@sebastinto sebastinto deleted the add-exported-tag-to-manifest branch May 23, 2021 08:59
@sebastinto
Copy link
Contributor Author

Actually, after having a conversation about these errors with @mikepenz, I found out that this library was not causing the issue. You do not need to add the android:exported attribute. Please see HERE for an explanation. Sorry about the trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants