Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding translation to portuguese #101

Merged
merged 4 commits into from
Oct 4, 2020

Conversation

mailysantos
Copy link
Contributor

@mailysantos mailysantos commented Oct 4, 2020

Description

This PR has requested changes in the issue regarding the translation into Portuguese of the texts contained in the file translations.yml.

Issue #98 - Add Portuguese translations for general strings

Required checklist:

  • My code matches the existing code style of this project.
  • One of these:
    • This is a new localization for existing content.
    • This is new content that is localized for all the locales that this project currently supports.
    • I described above how I plan to localize this content immediately after merging these changes.
    • Localization is not applicable to this change.
  • I have tested my code and it successfully builds for GitHub Pages and validates as AMP.

@devadvance
Copy link
Owner

Hey @mailysantos, great work! To resolve the merge conflicts, I recommend moving the id (Indonesian) translations to be above your Portuguese translations. That should resolve them.

For example, changing this:

  pt:
    name: Português
    prefix: /pt
  id:
    name: Bahasa
    prefix: /id

to this:

  id:
    name: Bahasa
    prefix: /id
  pt:
    name: Português
    prefix: /pt

_data/translations.yml Outdated Show resolved Hide resolved
Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @mailysantos fantastic contribution! Muito obrigado!

@devadvance devadvance merged commit fb865fd into devadvance:staging Oct 4, 2020
@mailysantos
Copy link
Contributor Author

Thank you, @devadvance! It is a very interesting project, I'll continue to follow. See you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants