Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Telugu translations for commands in basic.yml and files.yml, and for guide navigate-terminal.md #135

Merged
merged 17 commits into from
Oct 5, 2020
Merged

Adds Telugu translations for commands in basic.yml and files.yml, and for guide navigate-terminal.md #135

merged 17 commits into from
Oct 5, 2020

Conversation

shanmukhkalasamudram
Copy link
Contributor

@shanmukhkalasamudram shanmukhkalasamudram commented Oct 4, 2020 •
edited by devadvance
Loading

Description

Please include a summary of this change and the issue(s) you are fixing. Include any context or information that will help a reviewer verify this PR quickly. List any caveats or issues with this change up front.

Fixes #111
Fixes #88

Required checklist:

  • My code matches the existing code style of this project.
  • One of these:
    • This is a new localization for existing content.
    • This is new content that is localized for all the locales that this project currently supports.
    • I described above how I plan to localize this content immediately after merging these changes.
    • Localization is not applicable to this change.
  • I have tested my code and it successfully builds for GitHub Pages and validates as AMP.

@devadvance devadvance changed the title Commands for basic and files.yml Adds Telugu translations for commands in basic.yml and files.yml Oct 4, 2020
@devadvance devadvance changed the title Adds Telugu translations for commands in basic.yml and files.yml Adds Telugu translations for commands in basic.yml and files.yml, and for guide navigate-terminal.md Oct 4, 2020
@devadvance
Copy link
Owner

@shanmukhkalasamudram I updated the PR to have images and slightly different wording in the guide. Please review and let me know if it is OK. I also fixed the lint errors.

@shanmukhkalasamudram
Copy link
Contributor Author

Yeah, Its perfectly fine and I changes few alignments. Pls Accept my PR

devadvance
devadvance approved these changes Oct 5, 2020
View reviewed changes
Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution!

@devadvance devadvance merged commit bcad3f6 into devadvance:staging Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devadvance devadvance devadvance approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a Telugu translation of the navigate terminal guide Add Telugu translations for command descriptions
2 participants
@shanmukhkalasamudram @devadvance