Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Japanese and Chinese (Simplified) translations - fixed issue #166, #167 #173

Merged
merged 3 commits into from
Oct 31, 2020
Merged

Added Japanese and Chinese (Simplified) translations - fixed issue #166, #167 #173

merged 3 commits into from
Oct 31, 2020

Conversation

NickCwh
Copy link
Contributor

@NickCwh NickCwh commented Oct 31, 2020 •
edited
Loading

Description

Added Japanese translations into command descriptions for basic.yml and files.yml.
Added Chinese (Simplified) translations into command descriptions for basic.yml and files.yml.

Fixes #166 and #167

Required checklist:

  • My code matches the existing code style of this project.
  • One of these:
    • This is a new localization for existing content.
    • This is new content that is localized for all the locales that this project currently supports.
    • I described above how I plan to localize this content immediately after merging these changes.
    • Localization is not applicable to this change.
  • I have tested my code and it successfully builds for GitHub Pages and validates as AMP.

@NickCwh NickCwh changed the title Added Japanese translations and fixed issue #166 Added Japanese and Chinese (Simplified) translations - fixed issue #166, #167 Oct 31, 2020
devadvance
devadvance approved these changes Oct 31, 2020
View reviewed changes
Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for these helpful translations!

@devadvance devadvance merged commit 9c066a8 into devadvance:staging Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devadvance devadvance devadvance approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Japanese translations for command descriptions
2 participants
@NickCwh @devadvance