Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

French translation #79

Merged
merged 2 commits into from
Oct 3, 2020
Merged

French translation #79

merged 2 commits into from
Oct 3, 2020

Conversation

rayan-adamczak
Copy link
Contributor

@rayan-adamczak rayan-adamczak commented Oct 3, 2020 •
edited
Loading

Pull Request Template

Description

I "fixed" the issue #69 .

Required checklist:

  • My code matches the existing code style of this project.
  • One of these:
    • My content is localized for all of the locales that this project currently supports.
    • I described above how I plan to localize this content immediately after merging these changes.
  • I have tested my code and it successfully builds for GitHub Pages and validates as AMP.

rayan-adamczak and others added 2 commits October 3, 2020 10:45
devadvance
devadvance approved these changes Oct 3, 2020
View reviewed changes
Copy link
Owner

@devadvance devadvance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I adjusted the YAML header slightly (keys don't need to be translated) but otherwise is great. Thanks for the awesome contribution!

@devadvance devadvance merged commit 28ba74f into devadvance:staging Oct 3, 2020
@devadvance devadvance mentioned this pull request Oct 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devadvance devadvance devadvance approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rayan-adamczak @devadvance